Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] MDAnalysis self-dependency build fix #4502

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from
Draft

[CI] MDAnalysis self-dependency build fix #4502

wants to merge 14 commits into from

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Mar 10, 2024 •
edited

Fixes #4492

Work in progress:

  • Currently checking if we can just pick up the build via the src build directly

TODO:

  • Check package building
  • Check cron builds

Changes made in this Pull Request:

  • MDAKits are no longer in the direct pre-build install lists, they get picked up during the src build.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin

📚 Documentation preview 📚: https://mdanalysis--4502.org.readthedocs.build/en/4502/

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2024 •
edited

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov Codecov
Copy link

codecov bot commented Mar 10, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.87%. Comparing base (45fb664) to head (4977f2e).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4502      +/-   ##
===========================================
+ Coverage    93.64%   93.87%   +0.22%     
===========================================
  Files          168      180      +12     
  Lines        21254    22333    +1079     
  Branches      3918     3918              
===========================================
+ Hits         19904    20964    +1060     
- Misses         892      920      +28     
+ Partials       458      449       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay mentioned this pull request Apr 28, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Dependency resolution issues MDAnalysis installs
1 participant
@IAlibay