Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: updating Cython imports #3455

Closed
tylerjereddy opened this issue Nov 8, 2021 · 0 comments · Fixed by #3468
Closed

MAINT: updating Cython imports #3455

tylerjereddy opened this issue Nov 8, 2021 · 0 comments · Fixed by #3468

Comments

@tylerjereddy
Copy link
Member

Related to this for newer versions of Cython/NumPy: scipy/scipy#14813

There are a few places we could probably add in np.import_array() just to be safe later on. Compare the output of git grep -E -i 'cimport numpy' and git grep -E -i 'import_array' to see the spots where we might add it in.

I don't think it is urgent though, and to be fair MDA already does the right thing in a few places based on those greps. Probably just a useful guard to add at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants