Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support opentelemetry 0.18 #89

Merged
merged 2 commits into from Sep 20, 2022
Merged

Support opentelemetry 0.18 #89

merged 2 commits into from Sep 20, 2022

Conversation

asonix
Copy link
Contributor

@asonix asonix commented Sep 19, 2022 •
edited

closes #88

asonix
asonix commented Sep 19, 2022
View reviewed changes
Cargo.toml
emit_event_on_error = []

[dependencies]
actix-web = { version = "4", default-features = false }
pin-project = "1.0.0"
tracing = "0.1.19"
tracing-futures = "0.2.4"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this dependency wasn't used

LukeMathWalker
LukeMathWalker approved these changes Sep 20, 2022
View reviewed changes
Copy link
Owner

@LukeMathWalker LukeMathWalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LukeMathWalker LukeMathWalker merged commit 2ffc110 into LukeMathWalker:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeMathWalker LukeMathWalker LukeMathWalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opentelemetry 0.18 support
2 participants
@asonix @LukeMathWalker