Skip to content
This repository has been archived by the owner on Jun 2, 2019. It is now read-only.

Fixed parsing of non-regular files #2

Merged
merged 1 commit into from Sep 22, 2016

Conversation

paulijar
Copy link

This PR fixes a problem when parsing non-regular files like Linux pipes. Incorrect use of the system function fread caused all the data beyond the first ~16KB to be discarded with such files.

This same problem was reported for getID3 project in http://www.getid3.org/phpBB3/viewtopic.php?f=4&t=1930 and fixed with commit JamesHeinrich/getID3@0e6c1a3.

The problem fixed here is the root cause of the issue owncloud/music#518.

- In case the file analyzed is not a regular local file but e.g. a Linux pipe, the parser used to read only the first ~16KB of the file. If the total size of all the tags exceeded 16KB, then some tags could not be parsed. Typically, this prevented parsing the embedded cover art.
- The problem was caused by incorrect assumptions on the behavior of the system function fread.
@LukasReschke
Copy link
Owner

Thanks!

@LukasReschke LukasReschke merged commit 62f4de7 into LukasReschke:master Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants