Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow video stickers #16

Closed
LuckyTurtleDev opened this issue Jan 23, 2023 · 7 comments · Fixed by #32
Closed

allow video stickers #16

LuckyTurtleDev opened this issue Jan 23, 2023 · 7 comments · Fixed by #32

Comments

@LuckyTurtleDev
Copy link
Owner

LuckyTurtleDev commented Jan 23, 2023

need to convert webm to webp

@LuckyTurtleDev
Copy link
Owner Author

This should be possible with the matroska-demuxer and the image crate. Alternative instead of image the webp-animation can be used to avoid hassle with c dependencys (lotticonf and image use both libwebp).

@msrd0 what was the advance of the webp-animation over the image crate?

@msrd0
Copy link
Collaborator

msrd0 commented Aug 25, 2023

Iirc, at the time of choosing that library, the image crate did not support animated webp. no idea if this has changed since then.

@msrd0
Copy link
Collaborator

msrd0 commented Aug 25, 2023

And lottieconv uses webp-animation, not libwebp

@LuckyTurtleDev
Copy link
Owner Author

And lottieconv uses webp-animation, not libwebp

but web-animation use libwebp-sys2

@msrd0
Copy link
Collaborator

msrd0 commented Aug 25, 2023

Nvm, webp-animation also relies on the C library, so it looks like we cannot avoid the c dependency. Also we will always have a dependency on the rlottie C library.

@LuckyTurtleDev
Copy link
Owner Author

LuckyTurtleDev commented Aug 25, 2023

looks like the image crate is currently working on a pure rust webp decoder. see image-rs/image#1984

@msrd0 msrd0 linked a pull request Aug 27, 2023 that will close this issue
@LuckyTurtleDev
Copy link
Owner Author

LuckyTurtleDev commented Aug 27, 2023

Feature will be available at the next release

Thanks @msrd0 for impl this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants