New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images flicker on turbolinks reload #63

Open

LucasKuhn opened this issue Oct 9, 2020 · 1 comment · Fixed by #65

Owner

LucasKuhn commented Oct 9, 2020

Can be reproduced when disabling cache locally:
turbolinks/turbolinks#494
And a bit finicky on safari:
GoogleChrome/workbox#2540

Either way, adds cache for AWS:
https://stackoverflow.com/questions/55724341/where-do-i-set-cache-information-for-my-images
https://devcenter.heroku.com/articles/increasing-application-performance-with-http-cache-headers

LucasKuhn mentioned this issue

adds cache for aws images, makes loading bar prettier #65

Merged

LucasKuhn closed this as completed in #65

Owner Author

LucasKuhn commented Oct 10, 2020

Not solved!
Seems to be a Safari + Stimulus issue (needs confirmation if the behavior is OK without stimulus)
https://discourse.stimulusjs.org/t/stimulus-turbolinks-and-caching/1218
turbolinks/turbolinks#333
hotwired/stimulus#86

LucasKuhn reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment