Symfony Messenger plugin

[mathroc]

It would be nice to have a Symfony Messenger plugin

it does not dispatch events so it needs to be a middleware instead of an event subscriber, I don't know exactly how it should be added to the messenger buses middlewares from the bundle, here is how it looks in my config:

framework:
    messenger:
        buses:
            messenger.bus.default:
                middleware:
                   - App\Messenger\ResourceCleanerMiddleware
        transports:
            amqp: '%env(MESSENGER_TRANSPORT_DSN)%'
        routing:
            '*': amqp

and the middleware :

<?php declare(strict_types=1);

namespace App\Messenger;

use LongRunning\Core\DelegatingCleaner;
use Symfony\Component\Messenger\Envelope;
use Symfony\Component\Messenger\Middleware\MiddlewareInterface;
use Symfony\Component\Messenger\Middleware\StackInterface;

class ResourceCleanerMiddleware implements MiddlewareInterface
{
    /** @var DelegatingCleaner */
    private $cleaner;

    public function __construct(DelegatingCleaner $cleaner)
    {
        $this->cleaner = $cleaner;
    }

    public function handle(Envelope $envelope, StackInterface $stack): Envelope
    {
        try {
            $this->cleaner->cleanup();
            $envelope = $stack->next()->handle($envelope, $stack);
            $this->cleaner->cleanup();

            return $envelope;
        } catch (\Throwable $e) {
            $this->cleaner->cleanup();
            throw $e;
        }
    }
}

[ruudk]

Can you create a PR to add this as a plugin?

BTW: I think there is no need to call $this->cleaner->cleanup(); before handling the command.

[mathroc]

@ruudk it's suseful in case there's not been messages in a while and the connection broke

[ruudk]

But if you always cleanup after every message, there is nothing to cleanup after a while :)

[mathroc]

oh I see, connections stay closed between messages so they can't broke

[Koc]

Not sure that we really need plugin. IMHO separate middlewares like symfony/symfony#31334 and symfony/symfony#31061 is enough