Allow repr(transparent) to be used generically in derive(Pod)
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fu5ha
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
The idea seems good to me, will defer to @danielhenrymantilla on implementation review :)
danielhenrymantilla
approved these changes
Nov 2, 2022
|
Whoops, I guess I just run rustfmt before commit by instinct nowadays. |
|
rustfmt is no big deal, i do the same thing. |
|
Released |
leod
pushed a commit
to leod/bytemuck
that referenced
this pull request
Jun 3, 2023
…kathor#139) * Enabled transparent generics * Move trait checks to implementation block * Replace add_trait_marker impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My current use case is this:
However, the current
derivesystem only allows forrepr(packed)to be used with generics, despite the fact that, by definition,repr(transparent)contains no padding. This PR adds the option forrepr(transparent)to be used in this way.I also moved to checks on the actual implementation to the
implblock rather than being static, so thatMyNewtypecan also be used in the non-Podcase. I've verified that this works for my use case.