Fix try_pod_read_unaligned never having worked correctly
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like a copy-paste error has happened between `try_from_bytes`/`try_from_bytes_mut` and `try_pod_read_unaligned`, causing `internal::try_pod_read_unaligned` to try to read a &T::Bits instead of a T::Bits, usually failing with a `SizeMismatch` error. In the worst case, this allows UB in safe code by having a type allowing any bit pattern and being pointer-sized.
Lokathor
approved these changes
Oct 30, 2022
|
This looks like a correct fix. I'm going to ask @fu5ha to double check since did the rework with the |
fu5ha
approved these changes
Oct 30, 2022
|
released as |
|
Thanks for the quick merge and fix release! |
leod
pushed a commit
to leod/bytemuck
that referenced
this pull request
Jun 3, 2023
…or#138) It seems like a copy-paste error has happened between `try_from_bytes`/`try_from_bytes_mut` and `try_pod_read_unaligned`, causing `internal::try_pod_read_unaligned` to try to read a &T::Bits instead of a T::Bits, usually failing with a `SizeMismatch` error. In the worst case, this allows UB in safe code by having a type allowing any bit pattern and being pointer-sized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like a copy-paste error has happened between
try_from_bytes/try_from_bytes_mutandtry_pod_read_unaligned, causinginternal::try_pod_read_unalignedto try to read a&T::Bitsinstead of aT::Bits, and thus usually failing with aSizeMismatcherror.In the worst case, this allows UB in safe code by having a type allowing any bit pattern and being pointer-sized.