Fix something_went_wrong compile error on SPIR-V #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Display trait bound on the SPIR-V architecture.
|
I'm immediately wondering why this is generic over Debug, don't we always call it with an error value from this very crate anyway? Can't we just make that the type it accepts? But in the mean time yeah this seems good. |
|
According to the errors I got when compiling a shader it seems that it's only ever called with |
leod
pushed a commit
to leod/bytemuck
that referenced
this pull request
Jun 3, 2023
Removed Display trait bound on the SPIR-V architecture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Displaytrait is conditionally removed from the error types on the SPIR-V architecture, yetsomething_went_wrongstill has the trait bound. This results in the crate failing to compile for SPIR-V targets.This PR conditionally disables the trait bound on the function on SPIR-V to fix this issue.