Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken with I18n >= 1.9.0 #287

Closed
fabn opened this issue Feb 2, 2022 · 3 comments · Fixed by #288
Closed

Broken with I18n >= 1.9.0 #287

fabn opened this issue Feb 2, 2022 · 3 comments · Fixed by #288

Comments

@fabn
Copy link
Contributor

fabn commented Feb 2, 2022

Having this gem in bundle make app unusable when I18n >= 1.9.0 since they removed i18n/core_ext/hash in ruby-i18n/i18n#573
@ryanb ryanb mentioned this issue Feb 3, 2022
Merged
@ryanb
Copy link
Contributor

ryanb commented Feb 3, 2022

I submitted PR #288 to address this. You can use my branch until this is merged.

gem 'localeapp', github: 'ryanb/localeapp', branch: 'i18n-1-9'

Note: I haven't tested it beyond running the included specs.

@fabn
Copy link
Contributor Author

fabn commented Feb 3, 2022

Thanks @ryanb

@thibaultdalban
Copy link
Member

Thank you for reporting this @fabn 🙏 and thank you to @ryanb for fixing it 💪
V3.3.0 fixes the issue 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support i18n 1.9 ryanb/localeapp
3 participants
@ryanb @fabn @thibaultdalban