Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty version bump breaks unit tests #179

Closed
pietrygamat opened this issue Nov 1, 2022 · 1 comment · Fixed by #186
Closed

Netty version bump breaks unit tests #179

pietrygamat opened this issue Nov 1, 2022 · 1 comment · Fixed by #186
Assignees
Milestone

Comments

@pietrygamat
Copy link

The recent bump of netty version (#172 ) breaks the unit tests in org.littleshoot.proxy.impl.ProxyUtilsTest#testCommaSeparatedHeaderValues .
It is not immediately clear to me if the tests are in fact obsolete and need updating, or is there some sort of bug in the updated library, so this issue should be examined closer.
In the meantime however I believe the revert of the offending library is in order: (#178)

@valfirst
Copy link

I've filed Netty issue: netty/netty#13005. Let's see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants