Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add METEOR metric #595

Open
stancld opened this issue Oct 29, 2021 · 10 comments · May be fixed by #618
Open

Add METEOR metric #595

stancld opened this issue Oct 29, 2021 · 10 comments · May be fixed by #618
Labels
enhancement New feature or request good first issue Good for newcomers New metric topic: Text
Projects
Milestone

Comments

@stancld
Copy link
Contributor

stancld commented Oct 29, 2021

🚀 Feature

Add another NLP metric - METEOR (Lavie and Agarval, 2007).

Motivation

METEOR is another metric used for the machine translation evaluation similarly to BLEU, however, it demonstrates a higher correlation with human judgements of translation quality.

Pitch

To support the METEOR metric will be likely to require nltk dependency. The nltk package is also, however, needed for the ROUGE metric. METEOR thus should not bring any new dependency.

Additional context

I will be happy to start working on this feature next week if desired to be added :)

@stancld stancld added the enhancement New feature or request label Oct 29, 2021
@SkafteNicki
Copy link
Member

@stancld sounds great :]

@Borda
Copy link
Member

Borda commented Nov 3, 2021

@stancld do want to take it on your own or you can promote it on slack #new_contributions and then supervise it 🐰

@Borda Borda added this to the v0.7 milestone Nov 3, 2021
@Borda Borda added this to To do in Text via automation Nov 3, 2021
@stancld
Copy link
Contributor Author

stancld commented Nov 3, 2021

@Borda I've been working on that. :]

I've almost finished the implementation resembling the behaviour of the METEOR metric from nltk package. Once ready, I'll send a PR.

The aforementioned implementation is, however, based on the original paper (Lavie and Agarval, 2007) and thus is quite obsolete.

There is also a new version of this metric based on the paper of Denkowski and Lavie, 2014. I suggest doing this upgrade in another PR because it seems the only implementation of this metric is written in Java (see Meteor 1.5) (except for this python wrapper which directly utilizes the Java implementation) so it may take some extra time to implement it. (In general, I am trying to write the current implementation to be adaptable for newer versions)

@stancld stancld linked a pull request Nov 13, 2021 that will close this issue
10 tasks
@Borda Borda modified the milestones: v0.7, v0.8 Jan 6, 2022
@Borda Borda added the good first issue Good for newcomers label Jan 14, 2022
@Borda Borda changed the title [New metric] Add METEOR metric Add METEOR metric Jan 26, 2022
@SkafteNicki SkafteNicki modified the milestones: v0.8, v0.9 Apr 11, 2022
@SkafteNicki SkafteNicki removed this from the v0.9 milestone May 12, 2022
@SkafteNicki SkafteNicki added this to the future milestone Oct 26, 2022
@mattdias96
Copy link

Hey! This would be super useful to me, and I would love to contribute to make this work. Is there any way I can help?

@Borda
Copy link
Member

Borda commented Jan 24, 2023

@mattdias96 great! @stancld what do you think? 🐿️

@stancld
Copy link
Contributor Author

stancld commented Jan 24, 2023

Hey @mattdias96, do you mean the METEOR version 1.5? The thing is there's only Java implementation (I don't know Java 😬 ) + it'd be necessary to port several source files (here I'm not sure about copyrights, but I think this can be discussed w/ PL team, right @Borda?). In general, I expect it'd require large amounts of work to port this metric, but yeah, it'd be really cool to have it here.

I'd be a bit reluctant to add METEOR 1.0 used in some other python libraries, as this version is not used when referring to METEOR metric in papers, I guess.

@maliozer
Copy link

Did you finish and add this to the torchmetrics library ?

@stancld
Copy link
Contributor Author

stancld commented Sep 25, 2023

@maliozer Unfortunately not. Also, I think it would be pretty time-consuming to add the metric and I can't see it fitting into my schedule atm.

@stancld
Copy link
Contributor Author

stancld commented Sep 26, 2023

@maliozer However, feel free to give a try to add the metric if you want to :] It's currently not assigned.

@ThilinaTLM
Copy link

Does anyone working on this?
@stancld @maliozer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers New metric topic: Text
Projects
No open projects
Text
To do
Development

Successfully merging a pull request may close this issue.

8 participants
@maliozer @Borda @SkafteNicki @ThilinaTLM @stancld @mattdias96 and others