Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that nan is supported in zero_division #2535

Open
robmarkcole opened this issue May 12, 2024 · 1 comment
Open

Clarify that nan is supported in zero_division #2535

robmarkcole opened this issue May 12, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@robmarkcole
Copy link

This option added in #2198 to create equivalence with sklearn also supports passing through a nan if I am not mistaken, based on the implementation of torchmetrics.utilities.compute._safe_divide.
I wanted to clarify that nan can indeed be passed through, ask if any code changed are required to support this officially, and suggest this could be added to the docs which state currently zero_division [float] – Should be 0 or 1., e.g. here

@robmarkcole robmarkcole added the documentation Improvements or additions to documentation label May 12, 2024
Copy link

Hi! thanks for your contribution!, great first issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants