Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate use of join context for distributed sync #1338

Open
SkafteNicki opened this issue Nov 15, 2022 · 1 comment 路 May be fixed by #1886
Open

Investigate use of join context for distributed sync #1338

SkafteNicki opened this issue Nov 15, 2022 · 1 comment 路 May be fixed by #1886
Assignees
Labels
distributed DDP, etc. enhancement New feature or request
Milestone

Comments

@SkafteNicki
Copy link
Member

馃殌 Feature

Motivation

Based the problems from this issue: #1297
By implementing join context (https://pytorch.org/tutorials/advanced/generic_join.html) for our distributed syncronization we would remove the limitation that to correctly calculate a metric the number of samples needs to be divisible by num_gpus * batch_size (because pytorch by default is adding additional samples to load balance).

Pitch

Base class should derive from Joinable class and implement appropriate methods. It should hopefully not be too much trouble as all the sync logic is already encapsulated in a function.

Alternatives

Additional context

@SkafteNicki SkafteNicki added enhancement New feature or request distributed DDP, etc. labels Nov 15, 2022
@SkafteNicki SkafteNicki added this to the v0.11 milestone Nov 15, 2022
@justusschock justusschock self-assigned this Nov 15, 2022
@Borda Borda modified the milestones: v0.11, v0.12 Nov 18, 2022
@tabmoo
Copy link

tabmoo commented Nov 29, 2022

May using samplers like the one here be a temporary hack to obtain correct results?

@SkafteNicki SkafteNicki modified the milestones: v1.0.0, future May 23, 2023
@SkafteNicki SkafteNicki modified the milestones: future, v1.1.0 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed DDP, etc. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@Borda @justusschock @SkafteNicki @tabmoo and others