Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning when some of the modules are in eval mode before the training stage #19820

Open
mszulc913 opened this issue Apr 26, 2024 · 0 comments
Open

Add a warning when some of the modules are in eval mode before the training stage #19820

mszulc913 opened this issue Apr 26, 2024 · 0 comments
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers

Comments

@mszulc913
Copy link

mszulc913 commented Apr 26, 2024 •
edited

Description & Motivation

I feel like #18951 is not visible enough. The change made it super easy to have silent correctness bugs in the codebase when using libraries like huggingface.

Pitch

Add a warning about modules that are set to eval mode before training.

Alternatives

Update the documentation and tutorials.

Additional context

No response

cc @Borda
@mszulc913 mszulc913 added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mszulc913