Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running the cloud tests opens the UI #16070

Closed
carmocca opened this issue Dec 15, 2022 · 2 comments
Closed

Running the cloud tests opens the UI #16070

carmocca opened this issue Dec 15, 2022 · 2 comments
Labels
app Generic label for Lightning App package tests
Milestone
v1.8.x

Comments

@carmocca
Copy link
Member

carmocca commented Dec 15, 2022 •
edited

Bug description

Running tests that use CloudRuntime.dispatch will open a ton of browser tabs.

This is caused by the open_ui = True default set in #15875

One solution could be to do add an and not _running_tests() condition to https://github.com/Lightning-AI/lightning/blob/c4b27fb69cde2da72876c19184ef7494600ba86a/src/lightning_app/runners/cloud.py#L484

How to reproduce the bug

pytest tests/tests_app/runners/test_cloud.py

Error messages and logs

N/A

Environment

current master

More info

No response

cc @Borda
@carmocca carmocca added tests app Generic label for Lightning App package labels Dec 15, 2022
@carmocca carmocca added this to the v1.8.x milestone Dec 15, 2022
@carmocca
Copy link
Member Author

cc @ethanwharris @tchaton

@carmocca
Copy link
Member Author

carmocca commented Dec 20, 2022 •
edited

Fixed in https://github.com/Lightning-AI/lightning/pull/16114/files#diff-2d6c317d04ba3f0c68eaf887efc70f9b7f8dd241bcfe5fe6888ca07ae2bd38e3R501-R502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app Generic label for Lightning App package tests
Projects
None yet
Milestone
v1.8.x
Development

No branches or pull requests
1 participant
@carmocca