Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow apps to control when they become 'openable' from the website #14163

Closed
ethanwharris opened this issue Aug 11, 2022 · 2 comments
Closed
Labels
app Generic label for Lightning App package feature Is an improvement or enhancement

Comments

@ethanwharris
Copy link
Member

ethanwharris commented Aug 11, 2022

馃殌 Feature

Currently, the 'Open App' button becomes active as soon as the root flow / frontends are running. This can cause issues if your app relies on some works to have started (and perhaps done some processing) before it can be properly used (e.g. Flashy app has file servers that need to be running before you can upload data, some apps run streamlit from a work, etc.).

Pitch

Add a ready property or hook or something that the root flow can use to optionally signal that the app isn't ready to be opened yet.

Additional context

Currently apps like omniverse have a progress bar inside the app that it waits for it to be ready, but this means that users have to wait multiple times which isn't ideal.

cc @Borda

@ethanwharris ethanwharris added feature Is an improvement or enhancement app Generic label for Lightning App package labels Aug 11, 2022
@yurijmikhalevich
Copy link
Member

I agree that this would improve the experience a lot, plus it will free Lightning App developers from having to implement their own progress bar.

@awaelchli
Copy link
Member

I believe this was recently finished in #15921 :)
Please reopen if I'm mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Generic label for Lightning App package feature Is an improvement or enhancement
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants