From 9d564d8e17699291eb35fba919d0ebd3a390e11b Mon Sep 17 00:00:00 2001 From: Akash Kwatra Date: Tue, 1 Feb 2022 14:22:28 -0800 Subject: [PATCH] fix unit test according to suggestions --- tests/loggers/test_base.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/loggers/test_base.py b/tests/loggers/test_base.py index bb64b7a63fbed..3d416a600f955 100644 --- a/tests/loggers/test_base.py +++ b/tests/loggers/test_base.py @@ -176,7 +176,7 @@ def training_step(self, batch, batch_idx): assert logger2.finalized_status == "success" -def test_loggers_property(tmpdir): +def test_trainer_loggers_property(tmpdir): logger1 = CustomLogger() logger2 = CustomLogger() @@ -190,10 +190,10 @@ def test_loggers_property(tmpdir): assert trainer.loggers == [logger1] - # trainer.loggers should be None + # trainer.loggers should be an empty list trainer = Trainer(max_steps=2, log_every_n_steps=1, logger=False, default_root_dir=tmpdir) - assert trainer.loggers is [] + assert trainer.loggers == [] # trainer.loggers should be a list of size 1 holding the default logger trainer = Trainer(max_steps=2, log_every_n_steps=1, logger=True, default_root_dir=tmpdir)