Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: (SSIM) propagate device if gaussian_kernel is False, add test #1149

Merged
merged 10 commits into from Jul 19, 2022

Conversation

krshrimali
Copy link
Contributor

@krshrimali krshrimali commented Jul 16, 2022

What does this PR do?

Attempts to fix #1148 - summary of the changes:

  1. The device, dtype and channel are now propagated if gaussian_kernel is False.
  2. A test has been added as well.

Note to reviewers: I'm away from my GPU machine, so couldn't test this yet, I'll keep an eye on the CI, else I'll test it on my machine by tomorrow. (Tested on a GPU machine, all tests pass locally)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #1149 (2d6cb05) into master (19abf5e) will decrease coverage by 52%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #1149     +/-   ##
========================================
- Coverage      94%     42%    -52%     
========================================
  Files         185     185             
  Lines        8389    8389             
========================================
- Hits         7880    3539   -4341     
- Misses        509    4850   +4341     

@krshrimali krshrimali added the bug / fix Something isn't working label Jul 16, 2022
@mergify mergify bot added the ready label Jul 18, 2022
@Borda Borda enabled auto-merge (squash) July 18, 2022 11:32
Borda and others added 3 commits July 18, 2022 14:31
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
@mergify mergify bot removed the ready label Jul 18, 2022
@Borda
Copy link
Member

Borda commented Jul 18, 2022

@justusschock any other alternative for prod as it was added to math at 3.8, and we need to support 3.7,
see: https://stackoverflow.com/a/63737286/4521646

@mergify mergify bot added the ready label Jul 18, 2022
@Borda Borda merged commit 45ac6b0 into master Jul 19, 2022
@Borda Borda deleted the fix/gpu/ssim/not_gaussian_kernel branch July 19, 2022 07:38
Borda pushed a commit that referenced this pull request Jul 22, 2022
…1149)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
(cherry picked from commit 45ac6b0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
3 participants