Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "none" option to AveragePrecision #1116

Merged
merged 2 commits into from Jun 28, 2022
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jun 28, 2022

What does this PR do?

Fixes #1106
Docs state that average="none" is also an option for average precision metric, but currently it is not

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Jun 28, 2022
@SkafteNicki SkafteNicki added this to the v0.9 milestone Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #1116 (2ca577c) into master (d9c345b) will decrease coverage by 42%.
The diff coverage is 50%.

@@           Coverage Diff            @@
##           master   #1116     +/-   ##
========================================
- Coverage      94%     52%    -42%     
========================================
  Files         180     180             
  Lines        8079    8079             
========================================
- Hits         7594    4178   -3416     
- Misses        485    3901   +3416     

@mergify mergify bot added the ready label Jun 28, 2022
@Borda Borda merged commit bdb3e59 into master Jun 28, 2022
@Borda Borda deleted the bugfix/none_in_average_precision branch June 28, 2022 16:00
Borda pushed a commit that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor discrepancy in AveragePrecision documentation for average="none"
3 participants