Bugfix/avg prec auroc compute groups #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
justusschock,
tchaton,
ethanwharris and
SeanNaren
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1086 +/- ##
========================================
- Coverage 95% 79% -15%
========================================
Files 180 180
Lines 8078 8078
========================================
- Hits 7637 6392 -1245
- Misses 441 1686 +1245 |
Borda
approved these changes
Jun 13, 2022
justusschock
approved these changes
Jun 13, 2022
Borda
pushed a commit
that referenced
this pull request
Jun 14, 2022
* fix bugs * changelog (cherry picked from commit c2f55fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1084
Refactor some operations from
_updateto_computeinavg_precisionto make sure states inMetricCollectionare recognised as the same.Adds relevant tests
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 馃檭