Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward upgrade utils #1033

Merged
merged 26 commits into from May 24, 2022
Merged

forward upgrade utils #1033

merged 26 commits into from May 24, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 16, 2022

What does this PR do?

Follow up to #984

  • Change the default of the new full_state_update property to None. It will still works as full_state_update=True (old behavior) but a warning will be given to the user that they should consider setting the flag.
  • Add utility tool for checking if it is save to set the flag
  • Adds some tests

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@SkafteNicki SkafteNicki added Important milestonish refactoring refactoring and code health labels May 16, 2022
@SkafteNicki SkafteNicki added this to the v0.9 milestone May 16, 2022
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1033 (460aa1f) into master (a009bed) will decrease coverage by 0%.
The diff coverage is 93%.

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
- Coverage      95%     95%   -0%     
======================================
  Files         181     181           
  Lines        7882    7937   +55     
======================================
+ Hits         7474    7526   +52     
- Misses        408     411    +3     

tests/test_utilities.py Outdated Show resolved Hide resolved
torchmetrics/utilities/checks.py Outdated Show resolved Hide resolved
torchmetrics/utilities/checks.py Show resolved Hide resolved
torchmetrics/utilities/checks.py Outdated Show resolved Hide resolved
torchmetrics/metric.py Outdated Show resolved Hide resolved
torchmetrics/metric.py Outdated Show resolved Hide resolved
torchmetrics/utilities/checks.py Outdated Show resolved Hide resolved
torchmetrics/utilities/checks.py Outdated Show resolved Hide resolved
torchmetrics/metric.py Outdated Show resolved Hide resolved
torchmetrics/utilities/checks.py Outdated Show resolved Hide resolved
@mergify mergify bot added ready and removed ready labels May 19, 2022
@Borda Borda enabled auto-merge (squash) May 23, 2022 15:18
@mergify mergify bot added the ready label May 24, 2022
@Borda Borda merged commit 85d798e into master May 24, 2022
@Borda Borda deleted the refactor/forward_upgrade_utils branch May 24, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Important milestonish ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants