Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Update message regarding connection issues to the HF hub #1141

Merged
merged 3 commits into from Jul 12, 2022

Conversation

stancld
Copy link
Contributor

@stancld stancld commented Jul 12, 2022

What does this PR do?

When there's a connection issue to the HF hub, we try to catch this exception using skip_on_connection_issues decorator. However, it seems the error message has changed or there might be multiple ones. We thus catch more variants of potential raises.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added bug / fix Something isn't working Priority Critical task/issue test / CI testing or CI labels Jul 12, 2022
@Borda Borda added this to the v0.10 milestone Jul 12, 2022
@Borda Borda enabled auto-merge (squash) July 12, 2022 19:23
@Borda Borda modified the milestones: v0.10, v0.9 Jul 12, 2022
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1141 (8396b1b) into master (e7e6645) will decrease coverage by 43%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #1141     +/-   ##
========================================
- Coverage      94%     51%    -43%     
========================================
  Files         185     185             
  Lines        8389    8389             
========================================
- Hits         7880    4306   -3574     
- Misses        509    4083   +3574     

@Borda
Copy link
Member

Borda commented Jul 12, 2022

@stancld seeing another pattern:

E           OSError: Can't load config for 'google/bert_uncased_L-2_H-128_A-2'. Make sure that:
E           
E           - 'google/bert_uncased_L-2_H-128_A-2' is a correct model identifier listed on 'https://huggingface.co/models'
E           
E           - or 'google/bert_uncased_L-2_H-128_A-2' is the correct path to a directory containing a config.json file

@mergify mergify bot added the ready label Jul 12, 2022
@Borda Borda merged commit 6621c0f into master Jul 12, 2022
@Borda Borda deleted the bugfix/transformers-connection-issues branch July 12, 2022 21:00
@Borda
Copy link
Member

Borda commented Jul 12, 2022

seems one more case:

E               Failed: Timeout >120.0s

Borda pushed a commit that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working Priority Critical task/issue ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants