Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: JaccardIndex multi-label compute #1125

Merged
merged 4 commits into from Jul 10, 2022
Merged

Fix: JaccardIndex multi-label compute #1125

merged 4 commits into from Jul 10, 2022

Conversation

KeVoyer1
Copy link
Contributor

@KeVoyer1 KeVoyer1 commented Jul 4, 2022

What does this PR do?

The shape of the matrix in multi-label mode is (nb_classes, 2, 2) and currently the compute function needs a shape of (nb_classes, nb_classes). Easy fix by a for loop in the jaccardindex compute

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

the shape of the matrix in multi-label mode is (nb_classes, 2, 2)
@KeVoyer1 KeVoyer1 changed the title Fix multi-label error Fix: JaccardIndex multi-label compute Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #1125 (862ef09) into master (0d8b1b2) will decrease coverage by 42%.
The diff coverage is 67%.

@@           Coverage Diff            @@
##           master   #1125     +/-   ##
========================================
- Coverage      94%     52%    -42%     
========================================
  Files         182     182             
  Lines        8141    8143      +2     
========================================
- Hits         7648    4206   -3442     
- Misses        493    3937   +3444     

@mergify mergify bot added the ready label Jul 8, 2022
@Borda Borda enabled auto-merge (squash) July 10, 2022 11:03
@Borda Borda merged commit 883254e into Lightning-AI:master Jul 10, 2022
@KeVoyer1 KeVoyer1 deleted the patch-1 branch July 12, 2022 14:29
Borda pushed a commit that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants