Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug when providing superclass arguments as kwargs #1069

Merged
merged 16 commits into from Jun 7, 2022
Merged

Fix for bug when providing superclass arguments as kwargs #1069

merged 16 commits into from Jun 7, 2022

Conversation

jlcsilva
Copy link
Contributor

@jlcsilva jlcsilva commented Jun 6, 2022

What does this PR do?

Fixes #1068

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #1069 (04381ad) into master (35fcc88) will decrease coverage by 24%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #1069     +/-   ##
========================================
- Coverage      95%     71%    -24%     
========================================
  Files         181     181             
  Lines        8051    8085     +34     
========================================
- Hits         7620    5749   -1871     
- Misses        431    2336   +1905     

Signed-off-by: Jo茫o Louren莽o Silva <joao.lourenco.silva@tecnico.ulisboa.pt>
Signed-off-by: Jo茫o Louren莽o Silva <joao.lourenco.silva@tecnico.ulisboa.pt>
@Borda Borda added the bug / fix Something isn't working label Jun 6, 2022
@Borda Borda added this to the v0.9 milestone Jun 7, 2022
@mergify mergify bot added the ready label Jun 7, 2022
@Borda Borda enabled auto-merge (squash) June 7, 2022 10:27
@Borda
Copy link
Member

Borda commented Jun 7, 2022

Thank you! @jlcsilva mind checking the typing inconsistency flagged by mypy?
otherwise, we would like to include this in the next release this week 馃惏

@Borda Borda mentioned this pull request Jun 7, 2022
4 tasks
@Borda Borda merged commit 0a5d964 into Lightning-AI:master Jun 7, 2022
@jlcsilva
Copy link
Contributor Author

jlcsilva commented Jun 7, 2022

Thanks everyone! Didn't have the time to check the typing inconsistency earlier, but your fix looks good to me @Borda

@jlcsilva jlcsilva deleted the kwargs-bugfix branch June 7, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when providing superclass arguments as kwargs
4 participants