Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format encoded response #85

Merged
merged 4 commits into from May 14, 2024
Merged

format encoded response #85

merged 4 commits into from May 14, 2024

Conversation

aniketmaurya
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #84

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya self-assigned this May 11, 2024
@aniketmaurya aniketmaurya added the enhancement New feature or request label May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 78%. Comparing base (fc2afac) to head (814f263).

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #85   +/-   ##
==================================
- Coverage    79%   78%   -1%     
==================================
  Files         8     8           
  Lines       513   523   +10     
==================================
+ Hits        405   410    +5     
- Misses      108   113    +5     

@lantiga lantiga merged commit 56b691c into main May 14, 2024
19 checks passed
@lantiga lantiga deleted the aniket/stream-dump-dict branch May 14, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automatically dump dictionary to json in encode_response while Streaming
2 participants