Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the user know when "setup" has completed... #82

Merged
merged 3 commits into from May 14, 2024
Merged

Conversation

williamFalcon
Copy link
Contributor

Let the user know when "setup" has completed...

closes #81

Let the user know when "setup" has completed...

closes #81
Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (fc2afac) to head (f0670ac).

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #82   +/-   ##
==================================
  Coverage    79%   79%           
==================================
  Files         8     8           
  Lines       513   514    +1     
==================================
+ Hits        405   406    +1     
  Misses      108   108           

@williamFalcon williamFalcon changed the title Update server.py Let the user know when "setup" has completed... May 11, 2024
@williamFalcon
Copy link
Contributor Author

@aniketmaurya @lantiga is this the right place for this?

@aniketmaurya
Copy link
Collaborator

@williamFalcon yes, but I'd suggest using print instead of log here. Otherwise, whether it should print or not will depend on the user's default logging level. print will make sure that it always prints in the user's terminal.

@lantiga lantiga merged commit 7c658e2 into main May 14, 2024
19 checks passed
@lantiga lantiga deleted the williamFalcon-patch-1 branch May 14, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print "Setup complete" when setup is complete
3 participants