Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only enable either predict or stream-predict API based on stream argument to LitServer #47

Closed
aniketmaurya opened this issue Apr 16, 2024 · 2 comments
Closed

Only enable either predict or stream-predict API based on stream argument to LitServer #47

aniketmaurya opened this issue Apr 16, 2024 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@aniketmaurya
Copy link
Collaborator

aniketmaurya commented Apr 16, 2024 •
edited

LitServe uses /predict for regular and /stream-predict endpoint path with streaming mode.

We should only register either of these to FastAPI endpoint route or alternatively maybe just use /predict path for both the tasks by passing the relevant API function.

image

To Reproduce

Steps to reproduce the behavior:

Run a server LitServer(..., stream=True) flag
@aniketmaurya aniketmaurya added bug Something isn't working help wanted Extra attention is needed labels Apr 16, 2024
@aniketmaurya
Copy link
Collaborator Author

#76 should close this

@lantiga lantiga closed this as completed May 17, 2024
@lantiga
Copy link
Collaborator

lantiga commented May 17, 2024

Closed by #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lantiga @aniketmaurya