Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support GaLore #1075

Open
batman-do opened this issue Mar 9, 2024 · 3 comments · May be fixed by #1192
Open

support GaLore #1075

batman-do opened this issue Mar 9, 2024 · 3 comments · May be fixed by #1192

Comments

@batman-do
Copy link

Can repo support GaLore soon ?
https://github.com/jiaweizzhao/GaLore
@Andrei-Aksionov
Copy link
Collaborator

Hello @batman-do

It looks like GaLore is a drop-in replacement for the PyTorch optimizer, meaning that you can take any script that does pretraining/fine-tuning and replacement the part that defines optimizer.

@batman-do
Copy link
Author

Hello @batman-do

It looks like GaLore is a drop-in replacement for the PyTorch optimizer, meaning that you can take any script that does pretraining/fine-tuning and replacement the part that defines optimizer.

Can u support fsdp + qlora soon , i stuck oom when max_seq_length large when fine-tune lora > 24gb with model 7b

This was referenced Mar 21, 2024
Open
Open
@rasbt
Copy link
Collaborator

rasbt commented Mar 25, 2024

Can repo support GaLore soon ?

In the works via #1192 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce OptimizerArgs and add support for GaLore Lightning-AI/litgpt
3 participants
@rasbt @Andrei-Aksionov @batman-do