Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing dictionary data structures fails when using a partially initialized function #120

Open
enrico-stauss opened this issue May 6, 2024 · 2 comments

Comments

@enrico-stauss
Copy link
Contributor

When passing fn=partial(my_func, arg1=arg1) to optimize, the line linked below will yield only the keys of the dictionary that my_funcreturns. I avoided the issue by not using partial for my usecase but I`d consider this a bug.

Kind regards :)

if isinstance(self._fn, partial):

Copy link

github-actions bot commented May 6, 2024

Hi! thanks for your contribution!, great first issue!

@tchaton
Copy link
Collaborator

tchaton commented May 7, 2024

Hey @enrico-stauss, Could you try out the latest version of litdata ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants