Skip to content

Fix support for passing -1 to find_usable_cuda_devices function #16866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 27, 2023

Conversation

yhl48
Copy link
Contributor

@yhl48 yhl48 commented Feb 24, 2023

What does this PR do?

Fixes #16816

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Sorry, something went wrong.

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Feb 24, 2023
@carmocca carmocca added the community This PR is from the community label Feb 24, 2023
@awaelchli awaelchli added this to the v1.9.x milestone Feb 24, 2023
@awaelchli awaelchli changed the title find_usable_cuda_devices bug Fix support for passing -1 to find_usable_cuda_devices function Feb 24, 2023
@mergify mergify bot removed the has conflicts label Feb 24, 2023
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix!
Made minor edits to the test and added changelog
Cheers!

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #16866 (f6de49e) into master (e3efbaa) will decrease coverage by 22%.
The diff coverage is 100%.

❗ Current head f6de49e differs from pull request most recent head 7664008. Consider uploading reports for the commit 7664008 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #16866     +/-   ##
=========================================
- Coverage      82%      59%    -22%     
=========================================
  Files         437      413     -24     
  Lines       31665    31291    -374     
=========================================
- Hits        25864    18607   -7257     
- Misses       5801    12684   +6883     

@mergify mergify bot added the ready PRs ready to be merged label Feb 25, 2023
@awaelchli awaelchli enabled auto-merge (squash) February 26, 2023 00:16
@awaelchli awaelchli merged commit 4444d0c into Lightning-AI:master Feb 27, 2023
awaelchli added a commit that referenced this pull request Feb 27, 2023
…6866)


Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
awaelchli added a commit that referenced this pull request Feb 27, 2023
…6866)

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
awaelchli added a commit that referenced this pull request Feb 27, 2023
…6866)

Co-authored-by: Yi Heng Lim <limjohnyh@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
carmocca pushed a commit that referenced this pull request Feb 28, 2023
…6866)

Co-authored-by: Yi Heng Lim <limjohnyh@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
lexierule pushed a commit that referenced this pull request Feb 28, 2023
…6866)

Co-authored-by: Yi Heng Lim <limjohnyh@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community fabric lightning.fabric.Fabric ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find_usable_cuda_devices default value raises RuntimeError
4 participants