-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix support for passing -1 to find_usable_cuda_devices
function
#16866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for passing -1 to find_usable_cuda_devices
function
#16866
Conversation
find_usable_cuda_devices
function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the fix!
Made minor edits to the test and added changelog
Cheers!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #16866 +/- ##
=========================================
- Coverage 82% 59% -22%
=========================================
Files 437 413 -24
Lines 31665 31291 -374
=========================================
- Hits 25864 18607 -7257
- Misses 5801 12684 +6883 |
…6866) Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
…6866) Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
…6866) Co-authored-by: Yi Heng Lim <limjohnyh@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
…6866) Co-authored-by: Yi Heng Lim <limjohnyh@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
…6866) Co-authored-by: Yi Heng Lim <limjohnyh@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
What does this PR do?
Fixes #16816
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist