Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releasing: 1.8.6 #16134

Merged
merged 36 commits into from Dec 21, 2022
Merged

Releasing: 1.8.6 #16134

merged 36 commits into from Dec 21, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 20, 2022 •
edited by github-actions bot

What does this PR do?

regular weekly release

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

Sherin Thomas and others added 25 commits December 20, 2022 14:10
@Borda
chlog continued
3652718
@tchaton @Borda
[App] PoC: Add support for Request (#16047)
17e15af 
(cherry picked from commit 592b126)
@carmocca @Borda
Have checkgroup pull the latest runs (#16033)
d1ca635 
(cherry picked from commit 4c91dec)
@justusschock @Borda
Update Multinode Warning (#16091)
0db6b50 
(cherry picked from commit 3d509f6)
@Borda
[App] Serve datatypes with better client code (#16018)
87dd800 
(cherry picked from commit 23013be)
@Borda
docs: add PT version (#16010)
b519c59 
* docs: add PT version

* stable

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
(cherry picked from commit c8b4bce)
@Borda
add 1.13.1 to adjust versions (#16099)
ecaac18 
(cherry picked from commit acd48d3)
@tchaton @Borda
[App] Add display name property to the work (#16095)
1d8ba52 
Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
(cherry picked from commit 22b254f)
@awaelchli @Borda
Fix detection of whether app is running in cloud (#16045)
a9346c8 
(cherry picked from commit e54f4f5)
@tchaton @Borda
[App] Add work.delete (#16103)
6996dc8 
Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
(cherry picked from commit 80b7faf)
@akihironitta @Borda
[App] Improve the autoscaler UI (#16063)
a0f8f70 
[App] Improve the autoscaler UI (#16063)

(cherry picked from commit 39d27f6)
@Borda
[App] Min replica=0 would break autoscaler component (#16092)
c57af59 
* fixing the bug where num_replica=0 would fail

* changelog

(cherry picked from commit aba5f12)
@Borda
[App] Scale out/in interval for autoscaler (#16093)
3efeaaa 
* Adding arguments for scale out/in interval

* Tests

(cherry picked from commit 0fd3d54)
@awaelchli @Borda
Set the default work start method to spawn on MacOS (#16089)
be4129c 
(cherry picked from commit f3157f3)
@ethanwharris @Borda
[App] Add status endpoint, enable ready (#16075)
fb4d01c 
Co-authored-by: thomas chaton <thomas@grid.ai>
(cherry picked from commit 2a85d9b)
@carmocca @Borda
Clarify work.stop() limitation (#16073)
0c80e66 
(cherry picked from commit 0abd686)
@dependabot @Borda
Update torchvision requirement from <=0.14.0,>=0.11.1 to >=0.11.1,<0.…
9a08330 
…15.0 in /requirements (#16108)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>

(cherry picked from commit e8ac9e9)
@Borda
CI: settle file names (#16098)
0171f8a 
* CI: settle file names

* rename

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

(cherry picked from commit a203b04)
@tchaton @Borda
[App] Resolve some bugs from the Training Studio scaling (#16114)
2710b4d 
Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
(cherry picked from commit 51ec949)
@dependabot @Borda
Update scikit-learn requirement from <1.1.3,>0.22.1 to >0.22.1,<1.2.1…
2376960 
… in /requirements (#16107)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit d070e72)
@tchaton @Borda
[App] update app testing (#16000)
716abc9 
Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
(cherry picked from commit 8b68e20)
@tchaton @Borda
[App] Change overwrite to True (#16009)
da1133d 
Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
(cherry picked from commit 085c6b3)
@akihironitta @Borda
[App] Improve PythonServer info message on startup (#15989)
90822bc 
* change msg
* update chgl
* show the user's class name

(cherry picked from commit 848ea56)
@Borda
[App] Cold start proxy in autoscaler (#16094)
6697832 
* cold start proxy

* Update src/lightning_app/components/serve/auto_scaler.py

* changelog

* better-doc

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

(cherry picked from commit 7cbdc68)
@akihironitta @Borda
Fix endpoint information tab not showing up in AutoScaler UI (#16128)
0800063 
* .

* why

* Revert "why"

This reverts commit 375d3e8.

* tried api access with fixed values

* Revert "tried api access with fixed values"

This reverts commit f1720f6.

* Fix typo 🎉

* update chglog

* revert removing lines in chlog

* update chglog

Co-authored-by: Akihiro Nitta <akihiro@lightning.ai>
(cherry picked from commit 7b275bc)
@Borda Borda added the release label Dec 20, 2022
@Borda Borda added this to the v1.8.x milestone Dec 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2022 •
edited

🌩️ Required checks status: Pending 🟡

Groups summary

🟡 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.9, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) in_progress ⌛
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.9, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) in_progress ⌛
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.9, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, requirements/lite/base.txt, requirements/lite/examples.txt, requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt, tests/tests_pytorch/test_cli.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt, tests/tests_pytorch/test_cli.py, requirements/lite/base.txt, requirements/lite/examples.txt.

🟢 pytorch_lightning: Benchmarks
Check ID Status
pytorch-lightning.Benchmark success ✅

These checks are required after the changes to requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to requirements/lite/base.txt, requirements/lite/examples.txt, requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt, tests/tests_pytorch/test_cli.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to requirements/lite/base.txt, requirements/lite/examples.txt, requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt, tests/tests_pytorch/test_cli.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to docs/source-pytorch/index.rst, docs/source-pytorch/model/build_model.rst, requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt.

🟡 pytorch_lightning: Docker
Check ID Status
build-cuda (3.9, 1.10, 11.3.1) success ✅
build-cuda (3.9, 1.11, 11.3.1) in_progress ⌛
build-cuda (3.9, 1.12, 11.6.1) in_progress ⌛
build-cuda (3.9, 1.13, 11.6.1) in_progress ⌛
build-hpu (1.5.0, 1.11.0) success ✅
build-ipu (3.9, 1.9) in_progress ⌛
build-NGC success ✅
build-pl (3.9, 1.10, 11.3.1) success ✅
build-pl (3.9, 1.11, 11.3.1) success ✅
build-pl (3.9, 1.12, 11.6.1) success ✅
build-pl (3.9, 1.13, 11.6.1) success ✅
build-xla (3.7, 1.12) success ✅

These checks are required after the changes to requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt, requirements/lite/base.txt, requirements/lite/examples.txt.

🟢 lightning_lite: CPU workflow
Check ID Status
lite-cpu (macOS-11, lite, 3.8, 1.11) success ✅
lite-cpu (macOS-11, lite, 3.9, 1.12) success ✅
lite-cpu (macOS-11, lite, 3.10, 1.13) success ✅
lite-cpu (macOS-11, lite, 3.7, 1.9, oldest) success ✅
lite-cpu (ubuntu-20.04, lite, 3.8, 1.10) success ✅
lite-cpu (ubuntu-20.04, lite, 3.9, 1.11) success ✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.12) success ✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.13) success ✅
lite-cpu (ubuntu-20.04, lite, 3.7, 1.9, oldest) success ✅
lite-cpu (windows-2022, lite, 3.9, 1.11) success ✅
lite-cpu (windows-2022, lite, 3.10, 1.12) success ✅
lite-cpu (windows-2022, lite, 3.10, 1.13) success ✅
lite-cpu (windows-2022, lite, 3.7, 1.9, oldest) success ✅
lite-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
lite-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
lite-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to requirements/lite/base.txt, requirements/lite/examples.txt, .github/workflows/ci-tests-lite.yml.

🟢 lightning_lite: Azure GPU
Check ID Status
lightning-lite (GPUs) success ✅

These checks are required after the changes to requirements/lite/base.txt, requirements/lite/examples.txt.

🟡 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success ✅
app-pytest (macOS-11, app, 3.8, oldest) success ✅
app-pytest (macOS-11, lightning, 3.9, latest) in_progress ⌛
app-pytest (ubuntu-20.04, app, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅
app-pytest (windows-2022, app, 3.8, oldest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅

These checks are required after the changes to .github/workflows/ci-tests-app.yml, src/lightning_app/api/http_methods.py, src/lightning_app/cli/lightning_cli.py, src/lightning_app/components/__init__.py, src/lightning_app/components/multi_node/base.py, src/lightning_app/components/serve/__init__.py, src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/gradio.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/components/serve/serve.py, src/lightning_app/components/serve/streamlit.py, src/lightning_app/core/api.py, src/lightning_app/core/app.py, src/lightning_app/core/constants.py, src/lightning_app/core/flow.py, src/lightning_app/core/queues.py, src/lightning_app/core/work.py, src/lightning_app/runners/backends/mp_process.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/testing/testing.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/app_logs.py, src/lightning_app/utilities/app_status.py, src/lightning_app/utilities/cloud.py, src/lightning_app/utilities/enum.py, src/lightning_app/utilities/packaging/cloud_compute.py, src/lightning_app/utilities/scheduler.py, tests/tests_app/components/multi_node/test_base.py, tests/tests_app/components/serve/test_auto_scaler.py, tests/tests_app/components/serve/test_model_inference_api.py, tests/tests_app/components/serve/test_python_server.py, tests/tests_app/components/test_auto_scaler.py, tests/tests_app/conftest.py, tests/tests_app/core/test_lightning_api.py, tests/tests_app/core/test_lightning_app.py, tests/tests_app/core/test_lightning_flow.py, tests/tests_app/core/test_lightning_work.py, tests/tests_app/runners/backends/__init__.py, tests/tests_app/runners/backends/test_mp_process.py, tests/tests_app/runners/test_cloud.py, tests/tests_app/runners/test_multiprocess.py, tests/tests_app/storage/test_orchestrator.py, tests/tests_app/storage/test_path.py, tests/tests_app/structures/test_structures.py, tests/tests_app/utilities/packaging/test_cloud_compute.py, tests/tests_app/utilities/test_cloud.py, tests/tests_app/utilities/test_commands.py, tests/tests_app/utilities/test_git.py, tests/tests_app/utilities/test_load_app.py, tests/tests_app/utilities/test_proxies.py, requirements/app/cloud.txt, requirements/app/test.txt.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (macOS-11, app, 3.9, oldest) success ✅
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, oldest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅

These checks are required after the changes to .github/workflows/ci-examples-app.yml, src/lightning_app/api/http_methods.py, src/lightning_app/cli/lightning_cli.py, src/lightning_app/components/__init__.py, src/lightning_app/components/multi_node/base.py, src/lightning_app/components/serve/__init__.py, src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/gradio.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/components/serve/serve.py, src/lightning_app/components/serve/streamlit.py, src/lightning_app/core/api.py, src/lightning_app/core/app.py, src/lightning_app/core/constants.py, src/lightning_app/core/flow.py, src/lightning_app/core/queues.py, src/lightning_app/core/work.py, src/lightning_app/runners/backends/mp_process.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/testing/testing.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/app_logs.py, src/lightning_app/utilities/app_status.py, src/lightning_app/utilities/cloud.py, src/lightning_app/utilities/enum.py, src/lightning_app/utilities/packaging/cloud_compute.py, src/lightning_app/utilities/scheduler.py, tests/tests_examples_app/public/test_boring_app.py, examples/app_boring/app.py, examples/app_display_name/app.py, examples/app_server_with_auto_scaler/app.py, requirements/app/cloud.txt, requirements/app/test.txt.

🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success ✅

These checks are required after the changes to src/lightning_app/api/http_methods.py, src/lightning_app/cli/lightning_cli.py, src/lightning_app/components/__init__.py, src/lightning_app/components/multi_node/base.py, src/lightning_app/components/serve/__init__.py, src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/gradio.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/components/serve/serve.py, src/lightning_app/components/serve/streamlit.py, src/lightning_app/core/api.py, src/lightning_app/core/app.py, src/lightning_app/core/constants.py, src/lightning_app/core/flow.py, src/lightning_app/core/queues.py, src/lightning_app/core/work.py, src/lightning_app/runners/backends/mp_process.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/testing/testing.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/app_logs.py, src/lightning_app/utilities/app_status.py, src/lightning_app/utilities/cloud.py, src/lightning_app/utilities/enum.py, src/lightning_app/utilities/packaging/cloud_compute.py, src/lightning_app/utilities/scheduler.py, requirements/app/cloud.txt, requirements/app/test.txt, tests/tests_examples_app/public/test_boring_app.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅

These checks are required after the changes to src/lightning_app/api/http_methods.py, src/lightning_app/cli/lightning_cli.py, src/lightning_app/components/__init__.py, src/lightning_app/components/multi_node/base.py, src/lightning_app/components/serve/__init__.py, src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/gradio.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/components/serve/serve.py, src/lightning_app/components/serve/streamlit.py, src/lightning_app/core/api.py, src/lightning_app/core/app.py, src/lightning_app/core/constants.py, src/lightning_app/core/flow.py, src/lightning_app/core/queues.py, src/lightning_app/core/work.py, src/lightning_app/runners/backends/mp_process.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/testing/testing.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/app_logs.py, src/lightning_app/utilities/app_status.py, src/lightning_app/utilities/cloud.py, src/lightning_app/utilities/enum.py, src/lightning_app/utilities/packaging/cloud_compute.py, src/lightning_app/utilities/scheduler.py, docs/source-app/api_references.rst, requirements/app/cloud.txt, requirements/app/test.txt.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/app/cloud.txt, requirements/app/test.txt, requirements/lite/base.txt, requirements/lite/examples.txt, requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt, src/lightning_app/api/http_methods.py, src/lightning_app/cli/lightning_cli.py, src/lightning_app/components/__init__.py, src/lightning_app/components/multi_node/base.py, src/lightning_app/components/serve/__init__.py, src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/gradio.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/components/serve/serve.py, src/lightning_app/components/serve/streamlit.py, src/lightning_app/core/api.py, src/lightning_app/core/app.py, src/lightning_app/core/constants.py, src/lightning_app/core/flow.py, src/lightning_app/core/queues.py, src/lightning_app/core/work.py, src/lightning_app/runners/backends/mp_process.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/testing/testing.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/app_logs.py, src/lightning_app/utilities/app_status.py, src/lightning_app/utilities/cloud.py, src/lightning_app/utilities/enum.py, src/lightning_app/utilities/packaging/cloud_compute.py, src/lightning_app/utilities/scheduler.py, pyproject.toml.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, lite, 3.7) success ✅
install-pkg (ubuntu-22.04, lite, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, lite, 3.7) success ✅
install-pkg (macOS-12, lite, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, lite, 3.7) success ✅
install-pkg (windows-2022, lite, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅

These checks are required after the changes to src/lightning_app/api/http_methods.py, src/lightning_app/cli/lightning_cli.py, src/lightning_app/components/__init__.py, src/lightning_app/components/multi_node/base.py, src/lightning_app/components/serve/__init__.py, src/lightning_app/components/serve/auto_scaler.py, src/lightning_app/components/serve/gradio.py, src/lightning_app/components/serve/python_server.py, src/lightning_app/components/serve/serve.py, src/lightning_app/components/serve/streamlit.py, src/lightning_app/core/api.py, src/lightning_app/core/app.py, src/lightning_app/core/constants.py, src/lightning_app/core/flow.py, src/lightning_app/core/queues.py, src/lightning_app/core/work.py, src/lightning_app/runners/backends/mp_process.py, src/lightning_app/runners/cloud.py, src/lightning_app/runners/runtime.py, src/lightning_app/testing/testing.py, src/lightning_app/utilities/app_helpers.py, src/lightning_app/utilities/app_logs.py, src/lightning_app/utilities/app_status.py, src/lightning_app/utilities/cloud.py, src/lightning_app/utilities/enum.py, src/lightning_app/utilities/packaging/cloud_compute.py, src/lightning_app/utilities/scheduler.py, requirements/app/cloud.txt, requirements/app/test.txt, requirements/lite/base.txt, requirements/lite/examples.txt, requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/strategies.txt, requirements/pytorch/test.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

ethanwharris and others added 9 commits December 21, 2022 13:35
@ethanwharris @Borda
[App] Implement ready for components (#16129)
b0369a1 
(cherry picked from commit 711aec5)
@ethanwharris @Borda
[App] Fix e2e tests (#16146)
86d52df 
(cherry picked from commit c98b0c4)
@ethanwharris @Borda
[App] Remove outdated warning from cloud requirements (#16140)
4475a53 
(cherry picked from commit bf5fa35)
@ethanwharris @Borda
[App] Fix support for streamlit > 1.14 (#16139)
bce3a15 
(cherry picked from commit ec336bc)
@awaelchli @Borda
Fix broken link in "Build a Model" section of docs (#16025)
677cf93 
fix build model link

(cherry picked from commit 1c02288)
@Borda
drop colossalai from testing as no stable release yet (#16122)
f5c7b87 
(cherry picked from commit 1e16836)
@ethanwharris @Borda
[App] Simplify messaging in cloud dispatch (#16160)
445404e 
(cherry picked from commit 9657671)
@ethanwharris @Borda
[App] Add annotations endpoint (#16159)
18df651 
(cherry picked from commit 0630444)
@mauvilsa @Borda
Small fix in test_cli.py to avoid failure with future version of json…
16f66e1 
…argparse (#16156)

(cherry picked from commit 50331e0)
@Borda Borda changed the title Releasing/1.8.6 [wip] Releasing: 1.8.6 Dec 21, 2022
tchaton
tchaton approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Dec 21, 2022
@lantiga lantiga merged commit bffdc2f into release/stable Dec 21, 2022
@lantiga lantiga deleted the releasing/1.8.6 branch December 21, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanwharris ethanwharris ethanwharris approved these changes

@tchaton tchaton tchaton approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@hhsecond hhsecond Awaiting requested review from hhsecond

@carmocca carmocca Awaiting requested review from carmocca carmocca is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@akihironitta akihironitta Awaiting requested review from akihironitta

Assignees
No one assigned
Labels
ready PRs ready to be merged release
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Borda @ethanwharris @tchaton @lantiga @carmocca @justusschock @awaelchli @akihironitta @mauvilsa