New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 1.8.5.post #16086
Merged
Merged
release: 1.8.5.post #16086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
tchaton,
lantiga,
awaelchli,
hhsecond,
ethanwharris,
williamFalcon,
carmocca,
justusschock and
akihironitta
as code owners
December 16, 2022 08:39
ethanwharris
approved these changes
Dec 16, 2022
The examples use LightningLite syntax without the run method, which is only available in master
awaelchli
approved these changes
Dec 16, 2022
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci fix
awaelchli
force-pushed
the
releasing/1.8.5.post
branch
from
December 16, 2022 12:52
9044e65
to
61bb90e
Compare
carmocca
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preparing some minor post-release
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda