New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] Improve PythonServer info message on startup #15989

Merged

Borda merged 10 commits into master from bugfix/python-serve-startup-msg

Dec 20, 2022

Contributor

akihironitta commented Dec 9, 2022 •

edited by github-actions bot

What does this PR do?

Replaces the info message "Your app has started" because it's not precise and confusing. For example, when AutoScaler creates multiple PythonServers, you see the following log:

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
[n/a] Did you make sure to update the documentation with your changes? (if necessary)
[n/a] Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

github-actions bot added the app label

akihironitta marked this pull request as ready for review

December 9, 2022 14:43

akihironitta requested review from tchaton, lantiga, awaelchli, hhsecond and ethanwharris as code owners

December 9, 2022 14:43

akihironitta added 3 commits

December 9, 2022 23:43


          change msg

190eba9


          change msg

16f65d0


          update chgl

5fc4968

akihironitta force-pushed the bugfix/python-serve-startup-msg branch from d4dd769 to 5fc4968 Compare

December 9, 2022 14:43

Contributor

github-actions bot commented Dec 9, 2022 •

edited

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, app, 3.8, latest)	success	✅
app-pytest (macOS-11, app, 3.8, oldest)	success	✅
app-pytest (macOS-11, lightning, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅
app-pytest (windows-2022, app, 3.8, oldest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning_app/components/serve/python_server.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (macOS-11, app, 3.9, oldest)	success	✅
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, oldest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning_app/components/serve/python_server.py.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to src/lightning_app/components/serve/python_server.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning_app/components/serve/python_server.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning_app/components/serve/python_server.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, lite, 3.7)	success	✅
install-pkg (ubuntu-22.04, lite, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, lite, 3.7)	success	✅
install-pkg (macOS-12, lite, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, lite, 3.7)	success	✅
install-pkg (windows-2022, lite, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning_app/components/serve/python_server.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

akihironitta changed the title ~~[wip][App] Improve PythonServer info message~~ [wip][App] Improve PythonServer info message on startup

akihironitta changed the title ~~[wip][App] Improve PythonServer info message on startup~~ [App] Improve PythonServer info message on startup

akihironitta requested a review from nohalon

December 9, 2022 14:59

akihironitta self-assigned this


          show the user's class name

0ef08c1

akihironitta added this to the v1.8.x milestone


          Merge branch 'master' into bugfix/python-serve-startup-msg

c6e2c30

Borda enabled auto-merge (squash)

December 10, 2022 01:23

Borda approved these changes

View reviewed changes


          Merge branch 'master' into bugfix/python-serve-startup-msg

9e2c237

awaelchli approved these changes

View reviewed changes

mergify bot added the ready label

lantiga approved these changes

View reviewed changes

mergify bot added has conflicts and removed ready labels


          Merge branch 'master' into bugfix/python-serve-startup-msg

34fc49c

mergify bot added ready and removed has conflicts labels

mergify bot added ready has conflicts and removed ready labels


          Merge branch 'master' into bugfix/python-serve-startup-msg

3df7abc

akihironitta commented

View reviewed changes

src/lightning_app/CHANGELOG.md Outdated Show resolved Hide resolved


          Update src/lightning_app/CHANGELOG.md

b349d00

mergify bot added ready and removed has conflicts ready labels

ethanwharris approved these changes

View reviewed changes


          Merge branch 'master' into bugfix/python-serve-startup-msg

Borda merged commit 848ea56 into master

Borda deleted the bugfix/python-serve-startup-msg branch

December 20, 2022 05:36

carmocca pushed a commit that referenced this pull request


          [App] Improve PythonServer info message on startup (#15989)

19cb9ea

* change msg
* update chgl
* show the user's class name

carmocca pushed a commit that referenced this pull request


          [App] Improve PythonServer info message on startup (#15989)

1a0da69

* change msg
* update chgl
* show the user's class name

Borda pushed a commit that referenced this pull request


          [App] Improve PythonServer info message on startup (#15989)

90822bc

* change msg
* update chgl
* show the user's class name

(cherry picked from commit 848ea56)

carmocca pushed a commit that referenced this pull request


          [App] Improve PythonServer info message on startup (#15989)

f19a9d5

* change msg
* update chgl
* show the user's class name

carmocca pushed a commit that referenced this pull request


          [App] Improve PythonServer info message on startup (#15989)

3503c71

* change msg
* update chgl
* show the user's class name

carmocca pushed a commit that referenced this pull request


          [App] Improve PythonServer info message on startup (#15989)

d033f4c

* change msg
* update chgl
* show the user's class name

nicolai86 pushed a commit that referenced this pull request


          [App] Improve PythonServer info message on startup (#15989)

113ce8c

* change msg
* update chgl
* show the user's class name

lantiga pushed a commit that referenced this pull request


          Releasing: 1.8.6 (#16134)

bffdc2f

* chlog continued

* [App] PoC: Add support for Request (#16047)

(cherry picked from commit 592b126)

* Have checkgroup pull the latest runs (#16033)

(cherry picked from commit 4c91dec)

* Update Multinode Warning (#16091)

(cherry picked from commit 3d509f6)

* [App] Serve datatypes with better client code (#16018)

(cherry picked from commit 23013be)

* docs: add PT version (#16010)

* docs: add PT version

* stable

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
(cherry picked from commit c8b4bce)

* add 1.13.1 to adjust versions (#16099)

(cherry picked from commit acd48d3)

* [App] Add display name property to the work (#16095)

Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
(cherry picked from commit 22b254f)

* Fix detection of whether app is running in cloud (#16045)

(cherry picked from commit e54f4f5)

* [App] Add work.delete (#16103)

Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
(cherry picked from commit 80b7faf)

* [App] Improve the autoscaler UI (#16063)

[App] Improve the autoscaler UI (#16063)

(cherry picked from commit 39d27f6)

* [App] Min replica=0 would break autoscaler component (#16092)

* fixing the bug where num_replica=0 would fail

* changelog

(cherry picked from commit aba5f12)

* [App] Scale out/in interval for autoscaler (#16093)

* Adding arguments for scale out/in interval

* Tests

(cherry picked from commit 0fd3d54)

* Set the default work start method to spawn on MacOS (#16089)

(cherry picked from commit f3157f3)

* [App] Add status endpoint, enable `ready` (#16075)

Co-authored-by: thomas chaton <thomas@grid.ai>
(cherry picked from commit 2a85d9b)

* Clarify `work.stop()` limitation (#16073)

(cherry picked from commit 0abd686)

* Update torchvision requirement from <=0.14.0,>=0.11.1 to >=0.11.1,<0.15.0 in /requirements (#16108)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>

(cherry picked from commit e8ac9e9)

* CI: settle file names (#16098)

* CI: settle file names

* rename

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

(cherry picked from commit a203b04)

* [App] Resolve some bugs from the Training Studio scaling (#16114)

Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
(cherry picked from commit 51ec949)

* Update scikit-learn requirement from <1.1.3,>0.22.1 to >0.22.1,<1.2.1 in /requirements (#16107)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit d070e72)

* [App] update app testing (#16000)

Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
(cherry picked from commit 8b68e20)

* [App] Change overwrite to True (#16009)

Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
(cherry picked from commit 085c6b3)

* [App] Improve PythonServer info message on startup (#15989)

* change msg
* update chgl
* show the user's class name

(cherry picked from commit 848ea56)

* [App] Cold start proxy in autoscaler (#16094)

* cold start proxy

* Update src/lightning_app/components/serve/auto_scaler.py

* changelog

* better-doc

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

(cherry picked from commit 7cbdc68)

* Fix endpoint information tab not showing up in AutoScaler UI (#16128)

* .

* why

* Revert "why"

This reverts commit 375d3e8.

* tried api access with fixed values

* Revert "tried api access with fixed values"

This reverts commit f1720f6.

* Fix typo 🎉

* update chglog

* revert removing lines in chlog

* update chglog

Co-authored-by: Akihiro Nitta <akihiro@lightning.ai>
(cherry picked from commit 7b275bc)

* [App] Implement `ready` for components (#16129)

(cherry picked from commit 711aec5)

* [App] Fix e2e tests (#16146)

(cherry picked from commit c98b0c4)

* [App] Remove outdated warning from cloud requirements (#16140)

(cherry picked from commit bf5fa35)

* [App] Fix support for streamlit > 1.14 (#16139)

(cherry picked from commit ec336bc)

* Fix broken link in "Build a Model" section of docs (#16025)

fix build model link

(cherry picked from commit 1c02288)

* drop colossalai from testing as no stable release yet (#16122)

(cherry picked from commit 1e16836)

* [App] Simplify messaging in cloud dispatch (#16160)

(cherry picked from commit 9657671)

* [App] Add annotations endpoint (#16159)

(cherry picked from commit 0630444)

* Small fix in test_cli.py to avoid failure with future version of jsonargparse (#16156)

(cherry picked from commit 50331e0)

* Fix test failing on master due to bad auto-merge (#16118)

(cherry picked from commit 07b775f)

* ver1.8.6

Co-authored-by: Sherin Thomas <sherin@lightning.ai>
Co-authored-by: thomas chaton <thomas@grid.ai>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mauricio Villegas <mauricio_ville@yahoo.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lantiga lantiga approved these changes

awaelchli awaelchli approved these changes

Borda Borda approved these changes

ethanwharris ethanwharris approved these changes

tchaton Awaiting requested review from tchaton tchaton is a code owner

hhsecond Awaiting requested review from hhsecond

nohalon Awaiting requested review from nohalon