Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releasing/1.8.4.post #15988

Merged
merged 11 commits into from Dec 9, 2022
Merged

Releasing/1.8.4.post #15988

merged 11 commits into from Dec 9, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 9, 2022 •
edited by github-actions bot

What does this PR do?

appending for 1.8.4 release

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

lantiga and others added 8 commits December 9, 2022 15:06
@lantiga @Borda
Apply dynamo to training_step, validation_step, test_step, predict_st…
fceac35 
…ep (#15957)

* Apply dynamo to training_step, validation_step, test_step, predict_step

* Add entry to CHANGELOG.md

(cherry picked from commit edc9986)
@tchaton @Borda
[App] Resolve run installation (#15974)
81ff938 
(cherry picked from commit dd83587)
@akihironitta @Borda
App: Move AutoScaler dependency to extra requirements (#15971)
8038c7a 
* Make autoscaler dependency optional
* update chglog
* dont directly import aiohttp

(cherry picked from commit 346e936)

# Conflicts:
#	requirements/app/base.txt
#	src/lightning_app/CHANGELOG.md
@akihironitta @Borda
Avoid using the same port number for autoscaler works (#15966)
e718b82 
* dont hardcode port in python server
* add another chglog

(cherry picked from commit a72d268)
@Liyang90 @Borda
Fix action_name usage in XLAProfiler (#15886)
d1509ad 
* Fix `action_name` usage in `XLAProfiler`
* add changelog
* Update src/pytorch_ligh
* Update xla.py

Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

(cherry picked from commit c748f82)
@justusschock @Borda
Fix multinode cloud component (#15965)
b9bb24a 
* fix multinode cloud component
* add tests

(cherry picked from commit d21b899)
@Borda
ci: update signaling (#15981)
843786f 
* ci: update signaling
* config

(cherry picked from commit e56e7f1)
@justusschock @Borda
Fix cloudcomputes registration for structures (#15964)
ad1de34 
* fix cloudcomputes
* updates cloudcompute registration
* changelog

(cherry picked from commit 90a4c02)
@Borda Borda added the release label Dec 9, 2022
@Borda Borda added this to the v1.8.x milestone Dec 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022 •
edited

⛈️ Required checks status: Has failure 🔴

⚠️ This job will need to be re-run to merge your PR. If you do not have write access to the repository you can ask Lightning-AI/lai-frameworks to re-run it for you. If you push a new commit, all of CI will re-trigger ⚠️ If you have any other questions, you can reach out to carmocca for help.

Groups summary

🔴 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.9, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) failure ❌
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) failure ❌
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) failure ❌
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.9, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) in_progress ⌛
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.9, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅
🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅
🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅
🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅
🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅
🟢 lightning_lite: CPU workflow
Check ID Status
lite-cpu (macOS-11, lite, 3.8, 1.11) success ✅
lite-cpu (macOS-11, lite, 3.9, 1.12) success ✅
lite-cpu (macOS-11, lite, 3.10, 1.13) success ✅
lite-cpu (macOS-11, lite, 3.7, 1.9, oldest) success ✅
lite-cpu (ubuntu-20.04, lite, 3.8, 1.10) success ✅
lite-cpu (ubuntu-20.04, lite, 3.9, 1.11) success ✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.12) success ✅
lite-cpu (ubuntu-20.04, lite, 3.10, 1.13) success ✅
lite-cpu (ubuntu-20.04, lite, 3.7, 1.9, oldest) success ✅
lite-cpu (windows-2022, lite, 3.9, 1.11) success ✅
lite-cpu (windows-2022, lite, 3.10, 1.12) success ✅
lite-cpu (windows-2022, lite, 3.10, 1.13) success ✅
lite-cpu (windows-2022, lite, 3.7, 1.9, oldest) success ✅
lite-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
lite-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
lite-cpu (windows-2022, lightning, 3.8, 1.13) success ✅
🔴 lightning_lite: Azure GPU
Check ID Status
lightning-lite (GPUs) failure ❌
🔴 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success ✅
app-pytest (macOS-11, app, 3.8, oldest) failure ❌
app-pytest (macOS-11, lightning, 3.9, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅
app-pytest (windows-2022, app, 3.8, oldest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅
🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (macOS-11, app, 3.9, oldest) success ✅
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, oldest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅
🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success ✅
🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅
🟢 mypy
Check ID Status
mypy success ✅
🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, lite, 3.7) success ✅
install-pkg (ubuntu-22.04, lite, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, lite, 3.7) success ✅
install-pkg (macOS-12, lite, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, lite, 3.7) success ✅
install-pkg (windows-2022, lite, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅

This comment was automatically generated and updates for 60 minutes every 180 seconds.

Thank you for your contribution! 💜

@akihironitta @Borda
Document running dev lightning on the cloud (#15962)
5f862fd 
* document running dev lightning on the cloud

* document running dev lightning on the cloud

* Update .github/CONTRIBUTING.md

Co-authored-by: Noha Alon <nohalon@gmail.com>

* document running dev lightning on the cloud

* git clone & pip install -e

* Update .github/CONTRIBUTING.md

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

Co-authored-by: Noha Alon <nohalon@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit cfd00d3)
tchaton
tchaton approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda
Copy link
Member Author

Borda commented Dec 9, 2022

waiting for #15984

@ethanwharris @Borda
[App] Install exact version whn upgrading and not when testing (#15984)
74d796b 
* [App] Install exact version whn upgrading and not when testing
* Update CHANGELOG.md

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

(cherry picked from commit 1657ea8)
@Borda Borda changed the title Releasing/1.8.4.post [wip] Releasing/1.8.4.post Dec 9, 2022
@mergify mergify bot added the ready PRs ready to be merged label Dec 9, 2022
@lantiga lantiga merged commit 6a39743 into release/stable Dec 9, 2022
@lantiga lantiga deleted the releasing/1.8.4.post branch December 9, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@hhsecond hhsecond Awaiting requested review from hhsecond

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@carmocca carmocca Awaiting requested review from carmocca carmocca is a code owner

@akihironitta akihironitta Awaiting requested review from akihironitta

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees
No one assigned
Labels
ready PRs ready to be merged release
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Borda @tchaton @justusschock @lantiga @akihironitta @Liyang90 @ethanwharris