Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample datatype for Serve Component #15623

Merged
merged 41 commits into from Nov 10, 2022
Merged

Sample datatype for Serve Component #15623

merged 41 commits into from Nov 10, 2022

Conversation

hhsecond
Copy link
Contributor

@hhsecond hhsecond commented Nov 10, 2022 •
edited by github-actions bot

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

hhsecond and others added 30 commits November 10, 2022 01:06
introducing serve component
aa7da85
Merge branch 'master' into feature/serve-component
bdb9ee0
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
03bda90 
for more information, see https://pre-commit.ci
clean up tests
3d51575
clean up tests
865c678
doctest
f06b29d
mypy
df0e770
Merge branch 'master' into feature/serve-component
baa16f4
structure-fix
81370bd
Merge branch 'feature/serve-component' of github.com:Lightning-AI/lig…
64203b7 
…htning into feature/serve-component
Merge branch 'master' into feature/serve-component
b53832a
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8300c34 
for more information, see https://pre-commit.ci
cleanup
3ab7c3e
Merge branch 'master' into feature/serve-component
62c5d43
master
66167e2
cleanup
efd5125
test fix
0736c68
Merge branch 'master' into feature/serve-component
a10e363
addition
95e2fa1
Merge branch 'feature/serve-component' of github.com:Lightning-AI/lig…
eeffc62 
…htning into feature/serve-component
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0efeeb0 
for more information, see https://pre-commit.ci
test fix
100fb0b
Merge branch 'feature/serve-component' of github.com:Lightning-AI/lig…
6888d96 
…htning into feature/serve-component
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2485f26 
for more information, see https://pre-commit.ci
requirements
731aabf
Merge branch 'feature/serve-component' of github.com:Lightning-AI/lig…
187a9f9 
…htning into feature/serve-component
Merge branch 'master' into feature/serve-component
f46478c
getting future url
2568e6a
Merge branch 'feature/serve-component' of github.com:Lightning-AI/lig…
82f98d8 
…htning into feature/serve-component
url for local
210f1a2
@github-actions github-actions bot added the app Generic label for Lightning App package label Nov 10, 2022
@rlizzo rlizzo marked this pull request as ready for review November 10, 2022 18:11
ethanwharris
ethanwharris approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I guess we need to update the manifest (here: https://github.com/Lightning-AI/lightning/blob/7ec15ae43a5d3506f24036bed148ff37fe87c7a8/src/lightning_app/__setup__.py#L44) aswell for the image file?

tchaton
tchaton approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 10, 2022
@rlizzo
Copy link
Contributor

rlizzo commented Nov 10, 2022 •
edited

# DO NOT MERGE UNTIL @Borda updates the manifest files

edit: this has been completed

@lexierule lexierule merged commit 136a090 into master Nov 10, 2022
@lexierule lexierule deleted the sample-datatype branch November 10, 2022 19:39
Borda pushed a commit that referenced this pull request Nov 10, 2022
@Borda
Sample datatype for Serve Component (#15623)
8f5a9d3 
* introducing serve component

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* clean up tests

* clean up tests

* doctest

* mypy

* structure-fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* cleanup

* cleanup

* test fix

* addition

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* test fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* requirements

* getting future url

* url for local

* sample data typeg

* changes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* prediction

* updates

* updates

* manifest

* fix type error

* fixed test

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Rick Izzo <rick@grid.ai>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
(cherry picked from commit 136a090)
lexierule pushed a commit that referenced this pull request Nov 10, 2022
@lexierule
Sample datatype for Serve Component (#15623)
eb87018 
* introducing serve component

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* clean up tests

* clean up tests

* doctest

* mypy

* structure-fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* cleanup

* cleanup

* test fix

* addition

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* test fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* requirements

* getting future url

* url for local

* sample data typeg

* changes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* prediction

* updates

* updates

* manifest

* fix type error

* fixed test

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Rick Izzo <rick@grid.ai>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
(cherry picked from commit 136a090)
@Borda Borda mentioned this pull request Nov 10, 2022
Merged
12 tasks
carmocca pushed a commit to carmocca/lightning that referenced this pull request Nov 11, 2022
@pre-commit-ci @rlizzo
@Borda @carmocca
Sample datatype for Serve Component (Lightning-AI#15623)
3b41b62 
* introducing serve component

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* clean up tests

* clean up tests

* doctest

* mypy

* structure-fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* cleanup

* cleanup

* test fix

* addition

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* test fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* requirements

* getting future url

* url for local

* sample data typeg

* changes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* prediction

* updates

* updates

* manifest

* fix type error

* fixed test

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Rick Izzo <rick@grid.ai>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
@Borda Borda mentioned this pull request Nov 12, 2022
Merged
12 tasks
@nicolai86 nicolai86 mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanwharris ethanwharris ethanwharris approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@carmocca carmocca Awaiting requested review from carmocca carmocca is a code owner

Assignees
No one assigned
Labels
app Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hhsecond @rlizzo @ethanwharris @tchaton @lexierule @Borda