Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] Rename to new convention #15621

Merged
merged 3 commits into from Nov 10, 2022
Merged

[App] Rename to new convention #15621

merged 3 commits into from Nov 10, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 10, 2022 •
edited

What does this PR do?

Renaming asked by @williamFalcon to align with new conventions.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@tchaton tchaton changed the title [App] Apply renaming [App] Rename to new convention Nov 10, 2022
@github-actions github-actions bot added the app Generic label for Lightning App package label Nov 10, 2022
@tchaton tchaton self-assigned this Nov 10, 2022
@tchaton tchaton added this to the v1.8.x milestone Nov 10, 2022
@tchaton tchaton enabled auto-merge (squash) November 10, 2022 15:13
@lantiga lantiga merged commit 7ec15ae into master Nov 10, 2022
@lantiga lantiga deleted the rename_multi_node branch November 10, 2022 15:19
Borda pushed a commit that referenced this pull request Nov 10, 2022
@tchaton @Borda
[App] Rename to new convention (#15621)
55ae1e8 
* update

* update

(cherry picked from commit 7ec15ae)
lexierule pushed a commit that referenced this pull request Nov 10, 2022
@tchaton @lexierule
[App] Rename to new convention (#15621)
1a94594 
* update

* update

(cherry picked from commit 7ec15ae)
carmocca pushed a commit to carmocca/lightning that referenced this pull request Nov 11, 2022
@tchaton @carmocca
[App] Rename to new convention (Lightning-AI#15621)
00ec309 
* update

* update
@nicolai86 nicolai86 mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga lantiga approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@hhsecond hhsecond Awaiting requested review from hhsecond

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Assignees

@tchaton tchaton

Labels
app Generic label for Lightning App package
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tchaton @lantiga