Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TensorBase.div_ #340

Open
athitten opened this issue May 1, 2024 · 2 comments 路 May be fixed by #441
Open

Implement TensorBase.div_ #340

athitten opened this issue May 1, 2024 · 2 comments 路 May be fixed by #441
Labels
enhancement New feature or request nemo Issues needed to support NVIDIA NeMo models.

Comments

@athitten
Copy link

athitten commented May 1, 2024

馃殌 Feature

Implement TensorBase.div_

Motivation

NeMo's MegatronNeVaModel

cc @tfogal
@athitten athitten added the enhancement New feature or request label May 1, 2024
@athitten athitten mentioned this issue May 1, 2024
Open
@tfogal tfogal added the nemo Issues needed to support NVIDIA NeMo models. label May 1, 2024
@athitten athitten mentioned this issue May 1, 2024
Open
11 tasks
@k223kim
Copy link
Contributor

k223kim commented May 17, 2024

Hi Team!
While .div_ is a in-place version of .div, would it be acceptable to add TensorBase.div for this issue?

@k223kim k223kim linked a pull request May 22, 2024 that will close this issue
Open
4 tasks
@tfogal
Copy link
Collaborator

tfogal commented May 24, 2024

Hey Kaeun, sorry for the slow reply on this one! Must have slipped through.

We'd love to have you tackle TensorBase.div---thank you so much! Let's just make sure we leave this issue open after the div operator gets committed (as this would still require some effort to deal with inplace even after #441 makes it in). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request nemo Issues needed to support NVIDIA NeMo models.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added torch.div k223kim/lightning-thunder
3 participants
@tfogal @athitten @k223kim