Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added torch.all #355

Merged
merged 17 commits into from May 13, 2024
Merged

feat: added torch.all #355

merged 17 commits into from May 13, 2024

Conversation

k223kim
Copy link
Contributor

@k223kim k223kim commented May 3, 2024 •
edited

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #336. I have added logical_not to implement torch.all.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

⚡️

mruberry
mruberry reviewed May 6, 2024
View reviewed changes
thunder/clang/__init__.py Outdated Show resolved Hide resolved
mruberry
mruberry reviewed May 6, 2024
View reviewed changes
thunder/clang/__init__.py Outdated Show resolved Hide resolved
mruberry
mruberry reviewed May 6, 2024
View reviewed changes
thunder/tests/opinfos.py Outdated Show resolved Hide resolved
mruberry
mruberry reviewed May 6, 2024
View reviewed changes
thunder/torch/__init__.py Outdated Show resolved Hide resolved
mruberry
mruberry reviewed May 6, 2024
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @k223kim! I made a couple suggestions for logical_not, nothing major. If we could separate that into its own PR that'd be great. Then we can get that merged and return to looking at all!

@k223kim
Copy link
Contributor Author

k223kim commented May 6, 2024

Oh wow, thanks so much @mruberry for taking a look at this draft PR. I will submit a separate PR for logical not. Thanks for the kind suggestion!

@k223kim k223kim mentioned this pull request May 7, 2024
Merged
4 tasks
mruberry
mruberry reviewed May 8, 2024
View reviewed changes
thunder/tests/opinfos.py Outdated Show resolved Hide resolved
mruberry
mruberry reviewed May 8, 2024
View reviewed changes
thunder/torch/__init__.py Outdated Show resolved Hide resolved
@k223kim k223kim marked this pull request as ready for review May 9, 2024 14:02
mruberry
mruberry reviewed May 9, 2024
View reviewed changes
thunder/torch/__init__.py Outdated Show resolved Hide resolved
mruberry
mruberry reviewed May 9, 2024
View reviewed changes
thunder/torch/__init__.py Outdated Show resolved Hide resolved
mruberry
mruberry reviewed May 9, 2024
View reviewed changes
thunder/tests/opinfos.py Outdated Show resolved Hide resolved
mruberry
mruberry reviewed May 9, 2024
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, @k223kim. I made a few comments for your review

@k223kim
Copy link
Contributor Author

k223kim commented May 12, 2024

Hey @mruberry! Hope you had a great weekend. Made some updates based on your comments. Would be amazing if you can take a look!

mruberry
mruberry approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

The any_tensor OpInfo just needs to be added to reduction_ops

@mruberry mruberry merged commit 084101e into Lightning-AI:main May 13, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry mruberry approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta robieta is a code owner

@t-vi t-vi Awaiting requested review from t-vi t-vi is a code owner

@carmocca carmocca Awaiting requested review from carmocca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement TensorBase.all
2 participants
@k223kim @mruberry