Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TensorBase.masked_fill_ #335

Open
athitten opened this issue May 1, 2024 · 1 comment
Open

Implement TensorBase.masked_fill_ #335

athitten opened this issue May 1, 2024 · 1 comment
Labels
enhancement New feature or request nemo Issues needed to support NVIDIA NeMo models.

Comments

@athitten
Copy link

athitten commented May 1, 2024

馃殌 Feature

Implement TensorBase.masked_fill_

Motivation

NeMo's MegatronClipModel

cc @tfogal
@athitten athitten added the enhancement New feature or request label May 1, 2024
@tfogal tfogal added the nemo Issues needed to support NVIDIA NeMo models. label May 1, 2024
@athitten athitten mentioned this issue May 1, 2024
Open
11 tasks
@athitten athitten mentioned this issue May 24, 2024
Closed
@tfogal
Copy link
Collaborator

tfogal commented May 24, 2024

It's very plausible that we could use a functionalization pass to support this in NeMo; the input/output tensors are internal to the graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request nemo Issues needed to support NVIDIA NeMo models.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tfogal @mruberry @athitten