Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style the settings dialog better #4

Open
eliihen opened this issue Dec 29, 2017 · 2 comments
Open

Style the settings dialog better #4

eliihen opened this issue Dec 29, 2017 · 2 comments

Comments

@eliihen
Copy link
Contributor

eliihen commented Dec 29, 2017

The dialog

It currently does not look very good. It would be great if someone could style it better!

You need to add a styles.css file to the APITokenForm component directory and put the styles in there.

See:

@eliihen
Copy link
Contributor Author

eliihen commented Jan 1, 2018

@prattheev Awesome! Let me know if you have any questions.

I'll write a better contribution guide soon

@eliihen
Copy link
Contributor Author

eliihen commented Jan 2, 2018

Wow, awesome! You're going all in, I love it! 😄

I like 1, 7 and 13 the most. The dark sidebar contrasts really well with the rest of the page, and I think that's what drew me to these.

The video and text part of 13 is pretty cool. The typography is pretty nice, but we should make sure that it has sufficient contrast with the background.

I would also suggest that we make the video large if the user has a very large screen. It really bugs me with YouTube that the videos are so small on my large monitor. That's why videos resize to 100% of the display height right now while staying 16:9.

I did experiment with a sidebar earlier, but it was a bit challenging to get it to work with mobile, so I didn't bother. Also there are not that many pages (but there could be more eventually).

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant