Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide checksum in order to validate downloads from the website #6299

Open
iio7 opened this issue Mar 14, 2022 · 4 comments
Open

Please provide checksum in order to validate downloads from the website #6299

iio7 opened this issue Mar 14, 2022 · 4 comments

Comments

@iio7
Copy link

iio7 commented Mar 14, 2022

As the title says. It's impossible to validate a download. You need to provide at least sha1 checksums and some proper way of validation. These checksums cannot reside on the website because if the website gets compromised, so would the checksums.

@CvH
Copy link
Member

CvH commented Mar 15, 2022

We currently just offer https://releases.libreelec.tv/LibreELEC-RPi4.arm-10.0.2.img.gz?mirrorlist (https://....?mirrorlist) to view the sha256. Ofc this is not safe against compromising attacks, same goes to github and the website.

ideas welcome :)

@iio7
Copy link
Author

iio7 commented Mar 17, 2022

I suggest looking through some of the other open source projects to see how they do it, and then find one of the models that best suit your project. It's a must have.

@lrusak
Copy link
Member

lrusak commented Mar 17, 2022

@CvH we already generate sha256 of the image. We can just copy them over to the mirrors when copying the image?

@chewitt
Copy link
Member

chewitt commented Mar 17, 2022

@lrusak Hashes on the same server as the images are not trusted as an attacker who compromises the server can post a bad image and matching hashes. So we need to publish them from a different location, i.e. include them in the website blog post. I think we just need to update the JSON update script so they also generate the content needed for the blog post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants