Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors in documentation #803

Open
sofoxe1 opened this issue Mar 27, 2024 · 0 comments
Open

errors in documentation #803

sofoxe1 opened this issue Mar 27, 2024 · 0 comments

Comments

@sofoxe1
Copy link

sofoxe1 commented Mar 27, 2024

https://www.pycryptodome.org/src/protocol/dh

second code block:

missing from Crypto.PublicKey import ECC
from functools import partial is not used
TupleHash128 is used despite not being listed under "The kdf parameter must be a cryptographically secure key derivation function, not password-based. For instance, some reasonable choices are:"

third code block:

code generates ephemeral keys with names "U_ephemeral" and "V__ephemeral" but "U_priv" and "U_pub" are used in key_agreement

fourth code block:

typo from Crypto.Protocol.KDF import HDKF instead of from Crypto.Protocol.KDF import HKDF
kdf = functools.partial(HDK, - triple "o" and "HDK" instead of "HKDF"

different hash functions (SHAKE128,,SHA256,TupleHash128) are used for kdf across entire page

i have no idea about cryptography so i won't make a pull request

@sofoxe1 sofoxe1 changed the title errors in documentation? errors in documentation Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant