fix(directives): fix accessibility issues #1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3fun1
force-pushed
the
directive-accessibility-fix
branch
from
1250095
to
3c9e7f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases the suffix/prefix directives should not be linked to the input.
For example when the input contains a hint and a suffix, Voice Over reads the description of the input in a weird way.
The issue revolved around aria-describedBy, in the code the suffix/prefix was directly linked to the input, in this case aria-hidden wasn't doing anything.
More details can be found in the linked issue.
Fixes Input with text suffix: VoiceOver reads suffix even though aria-hidden is present
Checklist: