Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix / LL-3887 - Fix glitch with cosmos and tron account balance summary banner scrollview #1394

Merged

Conversation

nparigi-ledger
Copy link
Contributor

📝 Description

Fix glitch with cosmos and tron account balance summary banner scrollview

❓ Context

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@nparigi-ledger nparigi-ledger requested a review from a team as a code owner September 27, 2022 14:08
@vercel
Copy link

vercel bot commented Sep 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 27, 2022 at 2:11PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 27, 2022 at 2:11PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 27, 2022 at 2:11PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 27, 2022 at 2:11PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022

⚠️ No Changeset found

Latest commit: 62c2d62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 0.00% // Head: 44.16% // Increases project coverage by +44.16% 🎉

Coverage data is based on head (10010c5) compared to base (9200f74).
Patch has no changes to coverable lines.

❗ Current head 10010c5 differs from pull request most recent head 62c2d62. Consider uploading reports for the commit 62c2d62 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1394       +/-   ##
============================================
+ Coverage         0   44.16%   +44.16%     
============================================
  Files            0      624      +624     
  Lines            0    25996    +25996     
  Branches         0     7055     +7055     
============================================
+ Hits             0    11480    +11480     
- Misses           0    13378    +13378     
- Partials         0     1138     +1138     
Flag Coverage Δ
test 44.16% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/families/solana/api/chain/validators/bignum.ts 50.00% <0.00%> (ø)
...live-common/src/families/algorand/serialization.ts 33.33% <0.00%> (ø)
...r-live-common/src/families/cosmos/preloadedData.ts 100.00% <0.00%> (ø)
...bs/ledger-live-common/src/families/solana/utils.ts 24.28% <0.00%> (ø)
...s/ledger-live-common/src/families/bitcoin/cache.ts 33.33% <0.00%> (ø)
...mon/src/families/bitcoin/wallet-btc/crypto/qtum.ts 100.00% <0.00%> (ø)
...mmon/src/families/stellar/js-prepareTransaction.ts 29.41% <0.00%> (ø)
...ledger-live-common/src/exchange/swap/checkQuote.ts 90.90% <0.00%> (ø)
...ger-live-common/src/families/celo/hw-getAddress.ts 100.00% <0.00%> (ø)
...r-live-common/src/families/polkadot/transaction.ts 36.36% <0.00%> (ø)
... and 614 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

@nparigi-ledger

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@LFBarreto LFBarreto merged commit 2da52a7 into develop Sep 28, 2022
@LFBarreto LFBarreto deleted the bugfix/LIVE-3867-fix-cosmos-balance-summary-banner branch September 28, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants