Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot: Solana: remove test for "destination" that don't work for MAX #1391

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

gre
Copy link
Contributor

@gre gre commented Sep 27, 2022

📝 Description

solana devs will have to add the relevant test but i was too optimistic here thinking it would work like other coins. this should restore solana to pass the bot. a "hint" will appear that you need to define a destinationTest but it's better to have a ✅ test as before until this is added properly. b75896f#commitcomment-85144438

❓ Context

  • Impacted projects: bot
  • Linked resource(s): n/a

✅ Checklist

  • Test coverage tested by the bot
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@gre gre requested a review from a user September 27, 2022 13:08
@vercel
Copy link

vercel bot commented Sep 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ❌ Failed (Inspect) Sep 27, 2022 at 1:09PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 27, 2022 at 1:09PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 27, 2022 at 1:09PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 27, 2022 at 1:09PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022

⚠️ No Changeset found

Latest commit: 8ac335b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 66.66% // Head: 43.64% // Decreases project coverage by -23.01% ⚠️

Coverage data is based on head (329417f) compared to base (b75896f).
Patch has no changes to coverable lines.

❗ Current head 329417f differs from pull request most recent head 8ac335b. Consider uploading reports for the commit 8ac335b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1391       +/-   ##
============================================
- Coverage    66.66%   43.64%   -23.02%     
============================================
  Files            5      610      +605     
  Lines          171    25543    +25372     
  Branches        13     6974     +6961     
============================================
+ Hits           114    11149    +11035     
- Misses          57    13261    +13204     
- Partials         0     1133     +1133     
Flag Coverage Δ
test 43.64% <ø> (-23.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...js/packages/hw-transport-mocker/src/RecordStore.ts
...s/hw-transport-mocker/src/openTransportReplayer.ts
...ledgerjs/packages/hw-transport-mocker/src/index.ts
...hw-transport-mocker/src/createTransportReplayer.ts
...hw-transport-mocker/src/createTransportRecorder.ts
.../ledger-live-common/src/families/solana/tx-fees.ts 20.31% <0.00%> (ø)
...-live-common/src/families/cardano/postSyncPatch.ts 13.63% <0.00%> (ø)
libs/ledger-live-common/src/mock/helpers.ts 84.61% <0.00%> (ø)
...dger-live-common/src/exchange/swap/getKYCStatus.ts 46.66% <0.00%> (ø)
...live-common/src/bridge/react/useGlobalSyncState.ts 23.07% <0.00%> (ø)
... and 605 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gre gre merged commit f0156f8 into develop Sep 27, 2022
@gre gre deleted the support/bot-solana-send-max branch September 27, 2022 13:59
@github-actions
Copy link

@gre

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants