-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bot: Solana: remove test for "destination" that don't work for MAX #1391
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Codecov ReportBase: 66.66% // Head: 43.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1391 +/- ##
============================================
- Coverage 66.66% 43.64% -23.02%
============================================
Files 5 610 +605
Lines 171 25543 +25372
Branches 13 6974 +6961
============================================
+ Hits 114 11149 +11035
- Misses 57 13261 +13204
- Partials 0 1133 +1133
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
📝 Description
solana devs will have to add the relevant test but i was too optimistic here thinking it would work like other coins. this should restore solana to pass the bot. a "hint" will appear that you need to define a destinationTest but it's better to have a ✅ test as before until this is added properly. b75896f#commitcomment-85144438
❓ Context
bot
n/a
✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.