Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screenshots #1387

Merged
merged 7 commits into from
Sep 28, 2022
Merged

Update screenshots #1387

merged 7 commits into from
Sep 28, 2022

Conversation

chabroA
Copy link
Contributor

@chabroA chabroA commented Sep 27, 2022

📝 Description

Fix tests errors by updating screenshots and fixing import in UI lib

❓ Context

  • Impacted projects: ``
  • Linked resource(s): ``

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Sep 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Sep 27, 2022 at 6:46PM (UTC)
native-ui-storybook ✅ Ready (Inspect) Visit Preview Sep 27, 2022 at 6:46PM (UTC)
2 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 27, 2022 at 6:46PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 27, 2022 at 6:46PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022

⚠️ No Changeset found

Latest commit: 5549ebd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chabroA
Copy link
Contributor Author

chabroA commented Sep 27, 2022

/generate-screenshots

@chabroA chabroA changed the title test Update screenshots Sep 27, 2022
@github-actions
Copy link

github-actions bot commented Sep 27, 2022

@chabroA

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

The typecheck command is failing with the following error:
> Cannot find module '../../../../lib' or its corresponding type declarations

Update Box import to rely on source code rather than generated `lib`
folder to fix error
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 48.12% // Head: 43.64% // Decreases project coverage by -4.47% ⚠️

Coverage data is based on head (167634c) compared to base (13696ed).
Patch has no changes to coverable lines.

❗ Current head 167634c differs from pull request most recent head 5549ebd. Consider uploading reports for the commit 5549ebd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1387      +/-   ##
===========================================
- Coverage    48.12%   43.64%   -4.48%     
===========================================
  Files          688      610      -78     
  Lines        30322    25543    -4779     
  Branches      7908     6971     -937     
===========================================
- Hits         14591    11148    -3443     
+ Misses       14512    14346     -166     
+ Partials      1219       49    -1170     
Flag Coverage Δ
test 43.64% <ø> (-4.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/range.ts 94.87% <0.00%> (-2.57%) ⬇️
libs/ledger-live-common/src/env.ts 80.43% <0.00%> (ø)
libs/ledger-live-common/src/convert.ts 12.50% <0.00%> (ø)
libs/ledger-live-common/src/network.ts 70.93% <0.00%> (ø)
libs/ledger-live-common/src/promise.ts 57.44% <0.00%> (ø)
libs/ledger-live-common/src/api/Tron.ts 16.53% <0.00%> (ø)
libs/ledger-live-common/src/hw/index.ts 20.00% <0.00%> (ø)
libs/ledger-live-common/src/nft/hook.ts 33.33% <0.00%> (ø)
libs/ledger-live-common/src/api/Ripple.ts 29.16% <0.00%> (ø)
libs/ledger-live-common/src/api/socket.ts 8.19% <0.00%> (ø)
... and 315 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

chabroA added a commit that referenced this pull request Sep 28, 2022
chabroA added a commit that referenced this pull request Sep 28, 2022
@chabroA chabroA mentioned this pull request Sep 28, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD screenshots Screenshots have been updated ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants