synthetic dblclick events relate to left button #6628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of https://cgit.freedesktop.org/libreoffice/online/commit/?id=d0906c12d82e0242b0709349979a9061da9c6a83 - synthetic `dblclick` events spawned from `DomEvent.DoubleTap.js` shall refer to [button 0](https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/button#Return_value), so double taps can be interpreted as double clicks of the *left* button (instead of double clicks of an *`undefined`* button).
Schleuse
pushed a commit
to Schleuse/Leaflet
that referenced
this pull request
Dec 3, 2019
This is a backport of https://cgit.freedesktop.org/libreoffice/online/commit/?id=d0906c12d82e0242b0709349979a9061da9c6a83 - synthetic `dblclick` events spawned from `DomEvent.DoubleTap.js` shall refer to [button 0](https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/button#Return_value), so double taps can be interpreted as double clicks of the *left* button (instead of double clicks of an *`undefined`* button).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of https://cgit.freedesktop.org/libreoffice/online/commit/?id=d0906c12d82e0242b0709349979a9061da9c6a83 - synthetic
dblclickevents spawned fromDomEvent.DoubleTap.jsshall refer to button 0, so double taps can be interpreted as double clicks of the left button (instead of double clicks of anundefinedbutton).