Make DivIcon html option accept Element #6571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanSanchez
requested changes
Apr 14, 2019
src/layer/marker/DivIcon.js
Outdated
| @@ -44,7 +44,12 @@ export var DivIcon = Icon.extend({ | |||
| var div = (oldIcon && oldIcon.tagName === 'DIV') ? oldIcon : document.createElement('div'), | |||
| options = this.options; | |||
|
|
|||
| div.innerHTML = options.html !== false ? options.html : ''; | |||
| if (options.html instanceof Element) { | |||
| div.innerHTML = ''; | |||
There was a problem hiding this comment.
I'd rather see L.DomUtil.empty() in use here.
There was a problem hiding this comment.
Sure. No problem.
IvanSanchez
approved these changes
Apr 14, 2019
Schleuse
pushed a commit
to Schleuse/Leaflet
that referenced
this pull request
Dec 3, 2019
* Make DivIcon html option accept Element * Empty div with L.DomUtil.empty * Docstrings for passing `HTMLElement` to DivIcon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the possibility to use a DOM
Elementinstance as thehtmloption for aDivIcon.